mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-03 23:00:14 -05:00
03b0139ef9
closes: https://github.com/TryGhost/Ghost/issues/10042 closes: https://github.com/TryGhost/Ghost/issues/14206 - the fact that pages are exposed as .page in dynamic routing has never played nicely - this fix changes nothing in the tests - which shows this was never a covered case - ideally I should add some tests, but for now this tiny change should prevent a lot of dynamic routing pain - note, it doesn't remove .page, it just adds .post, so both work
71 lines
1.8 KiB
JavaScript
71 lines
1.8 KiB
JavaScript
const _ = require('lodash');
|
|
const {prepareContextResource} = require('../proxy');
|
|
|
|
/**
|
|
* @description Formats API response into handlebars/theme format.
|
|
*
|
|
* @return {Object} containing page variables
|
|
*/
|
|
function formatPageResponse(result, pageAsPost = false) {
|
|
const response = {};
|
|
|
|
if (result.posts) {
|
|
response.posts = result.posts;
|
|
prepareContextResource(response.posts);
|
|
}
|
|
|
|
if (result.meta && result.meta.pagination) {
|
|
response.pagination = result.meta.pagination;
|
|
}
|
|
|
|
_.each(result.data, function (data, name) {
|
|
prepareContextResource(data);
|
|
|
|
if (data.meta) {
|
|
// Move pagination to be a top level key
|
|
response[name] = data;
|
|
response[name].pagination = data.meta.pagination;
|
|
delete response[name].meta;
|
|
} else {
|
|
// This is a single object, don't wrap it in an array
|
|
response[name] = data[0];
|
|
}
|
|
});
|
|
|
|
if (pageAsPost && response.page) {
|
|
response.post = response.page;
|
|
}
|
|
|
|
return response;
|
|
}
|
|
|
|
/**
|
|
* @description Format a single resource for handlebars.
|
|
*
|
|
* @TODO
|
|
* In the future, we should return {page: entry} or {post:entry).
|
|
* But for now, we would break the themes if we just change it.
|
|
*
|
|
* @see https://github.com/TryGhost/Ghost/issues/10042.
|
|
*
|
|
* @return {Object} containing page variables
|
|
*/
|
|
function formatResponse(post, context) {
|
|
prepareContextResource(post);
|
|
|
|
let entry = {
|
|
post: post
|
|
};
|
|
|
|
// NOTE: preview context is a special case where the internal preview api returns the post model's type field
|
|
if (context?.includes('page') || (context?.includes('preview') && post.type === 'page')) {
|
|
entry.page = post;
|
|
}
|
|
|
|
return entry;
|
|
}
|
|
|
|
module.exports = {
|
|
entries: formatPageResponse,
|
|
entry: formatResponse
|
|
};
|