0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
ghost/core/test/unit
Hannah Wolfe e4a1797085 Remove should-sinon dependency
no issue

- removes should-sinon dependency from package.json
- rewrites all usages of should-sinon to use normal should assertions

Unfortunately, should-sinon has very minimal documentation  and therefore it is hard to discern what is considered a correctly-written assertion:
- in some cases, refactoring to use should-sinon causes false positives
- in other cases, assertions that work written in the normal way fail when written using should-sinon (e.g. getters, combos with rewire)
The additional overhead created by these issues outweigh any benefit from the easier-to-read assertions
2016-03-14 16:52:22 +00:00
..
controllers/frontend Merge pull request #6507 from cameronviner/6505 2016-02-18 07:44:23 +00:00
metadata Strutured data: Slack Unfurls & published_at fix 2016-02-22 01:45:00 +01:00
middleware Remove should-sinon dependency 2016-03-14 16:52:22 +00:00
models_plugins Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
server_helpers Fix facebook/twitter/schema description 2016-02-18 12:11:46 +00:00
api_utils_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
apps_filters_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
apps_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
config_spec.js Exporter cleanup & tests 2016-03-12 19:01:25 +00:00
error_handling_spec.js Merge pull request #6507 from cameronviner/6505 2016-02-18 07:44:23 +00:00
exporter_spec.js Remove should-sinon dependency 2016-03-14 16:52:22 +00:00
filters_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
ghost_url_spec.js ensure null query options don't break ghost-url 2016-02-29 00:25:38 -06:00
importer_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
mail_spec.js deps: bluebird@3.1.2 2016-03-01 14:47:23 -06:00
migration_fixture_spec.js Refactor & test fixture migrations 2016-03-03 09:03:37 +00:00
migration_spec.js Refactor & test fixture migrations 2016-03-03 09:03:37 +00:00
permissions_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
rss_spec.js Merge pull request #6507 from cameronviner/6505 2016-02-18 07:44:23 +00:00
server_helpers_index_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
server_helpers_template_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
server_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
server_utils_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
showdown_client_integrated_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
sitemap_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
storage_local-file-store_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
utils_pipeline_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
versioning_spec.js Refactor & test fixture migrations 2016-03-03 09:03:37 +00:00
xmlrpc_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00