mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-03-11 02:12:21 -05:00
Update for synchronous feature service Add client-side handling of server-side errors when adding subscribers - display server-provided error message when we get a server error - fix the ajax util's `getRequestErrorMessage` method so that it works correctly with Ember's `InvalidError` object instead of the previous request object that it was receiving (*TODO:* this really needs looking at properly so we aren't losing details and Ember Data can do it's stuff) Styling updates - proper icon for ascending/descending - change hover colour to green for "Import CSV" button Delete subscriber button with confirm modal - display delete button when hovering over a subscriber row (WARN: really ugly button, styles definitely want looking at) - show confirm modal when clicking the delete button - delete subscriber, remove from table, and update total on confirm
49 lines
1.5 KiB
JavaScript
49 lines
1.5 KiB
JavaScript
import Ember from 'ember';
|
|
|
|
const {isArray} = Ember;
|
|
|
|
// TODO: this should be removed and instead have our app serializer properly
|
|
// process the response so that errors can be tied to the model
|
|
|
|
// Used in API request fail handlers to parse a standard api error
|
|
// response json for the message to display
|
|
export default function getRequestErrorMessage(request, performConcat) {
|
|
let message,
|
|
msgDetail;
|
|
|
|
// Can't really continue without a request
|
|
if (!request) {
|
|
return null;
|
|
}
|
|
|
|
// Seems like a sensible default
|
|
message = request.statusText;
|
|
|
|
// If a non 200 response
|
|
if (request.status !== 200) {
|
|
try {
|
|
// Try to parse out the error, or default to 'Unknown'
|
|
if (request.errors && isArray(request.errors)) {
|
|
message = request.errors.map((errorItem) => {
|
|
return errorItem.message;
|
|
});
|
|
} else {
|
|
message = request.error || 'Unknown Error';
|
|
}
|
|
} catch (e) {
|
|
msgDetail = request.status ? `${request.status} - ${request.statusText}` : 'Server was not available';
|
|
message = `The server returned an error (${msgDetail}).`;
|
|
}
|
|
}
|
|
|
|
if (performConcat && isArray(message)) {
|
|
message = message.join('<br />');
|
|
}
|
|
|
|
// return an array of errors by default
|
|
if (!performConcat && typeof message === 'string') {
|
|
message = [message];
|
|
}
|
|
|
|
return message;
|
|
}
|