0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-18 02:21:47 -05:00
ghost/core
Hannah Wolfe e4a1797085 Remove should-sinon dependency
no issue

- removes should-sinon dependency from package.json
- rewrites all usages of should-sinon to use normal should assertions

Unfortunately, should-sinon has very minimal documentation  and therefore it is hard to discern what is considered a correctly-written assertion:
- in some cases, refactoring to use should-sinon causes false positives
- in other cases, assertions that work written in the normal way fail when written using should-sinon (e.g. getters, combos with rewire)
The additional overhead created by these issues outweigh any benefit from the easier-to-read assertions
2016-03-14 16:52:22 +00:00
..
client deps: ember-cli@2.4.2 2016-03-07 09:17:51 +00:00
server Exporter cleanup & tests 2016-03-12 19:01:25 +00:00
shared ensure null query options don't break ghost-url 2016-02-29 00:25:38 -06:00
test Remove should-sinon dependency 2016-03-14 16:52:22 +00:00
index.js Misc grunt /dev updates 2015-05-28 20:25:14 +01:00