0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
ghost/core
Daniel Lockyer ddaa4ee5e1 Removed unnecessary checks during initial DB init
refs https://github.com/TryGhost/Toolbox/issues/202

- during DB init, we have to create all the tables
- right now we loop over all tables and call the `createTable` command
  - this command checks if the table exists and if not, creates the table
  - this works fine but it means we query the database for every table
  - in MySQL, we query the information_schema table, which we've seen
    issues with before because it doesn't have indexes
- the smarter thing to do here is to get all the tables that already exist,
  remove them from the list, and just straight up create them without
  further checks
- this entire thing should be protected by the migration lock so we
  shouldn't encounter issues from multiple processes initializing the DB
  and tables existing after the initial check
- this commit also removes the check from `createTable` because this isn't
  really needed. We should be using the migration utils, which do
  check for existing tables. I've added a note to the function and
  audited anywhere we still call the function
- this commit removes (- 49 tables + 1 initial check) 48 queries from
  the initial DB init
2022-02-21 08:44:40 +01:00
..
client@792f10f50c Updated Admin to v4.36.2 2022-02-18 16:00:29 +00:00
frontend 🐛 Fixed AssetHelper not working with svg (#13978) 2022-02-07 15:07:18 +00:00
server Removed unnecessary checks during initial DB init 2022-02-21 08:44:40 +01:00
shared Added test-specific default-settings.json configuration 2022-02-21 20:06:20 +13:00
app.js Fixed express app stacking 2021-12-06 21:28:53 +13:00
boot.js Added handler for unhandled rejections 2022-02-18 10:35:36 +01:00
bridge.js 💡 Pinned frontend API version to canary 2022-02-17 17:55:55 +00:00