mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-03 23:00:14 -05:00
1882278b5b
- 🛠 add bunyan and prettyjson, remove morgan - ✨ add logging module - GhostLogger class that handles setup of bunyan - PrettyStream for stdout - ✨ config for logging - @TODO: testing level fatal? - ✨ log each request via GhostLogger (express middleware) - @TODO: add errors to output - 🔥 remove errors.updateActiveTheme - we can read the value from config - 🔥 remove 15 helper functions in core/server/errors/index.js - all these functions get replaced by modules: 1. logging 2. error middleware handling for html/json 3. error creation (which will be part of PR #7477) - ✨ add express error handler for html/json - one true error handler for express responses - contains still some TODO's, but they are not high priority for first implementation/integration - this middleware only takes responsibility of either rendering html responses or return json error responses - 🎨 use new express error handler in middleware/index - 404 and 500 handling - 🎨 return error instead of error message in permissions/index.js - the rule for error handling should be: if you call a unit, this unit should return a custom Ghost error - 🎨 wrap serve static module - rule: if you call a module/unit, you should always wrap this error - it's always the same rule - so the caller never has to worry about what comes back - it's always a clear error instance - in this case: we return our notfounderror if serve static does not find the resource - this avoid having checks everywhere - 🎨 replace usages of errors/index.js functions and adapt tests - use logging.error, logging.warn - make tests green - remove some usages of logging and throwing api errors -> because when a request is involved, logging happens automatically - 🐛 return errorDetails to Ghost-Admin - errorDetails is used for Theme error handling - 🎨 use 500er error for theme is missing error in theme-handler - 🎨 extend file rotation to 1w
43 lines
1.1 KiB
JavaScript
43 lines
1.1 KiB
JavaScript
// ### Page URL Helper
|
|
//
|
|
// *Usage example:*
|
|
// `{{page_url 2}}`
|
|
//
|
|
// Returns the URL for the page specified in the current object
|
|
// context.
|
|
//
|
|
// We use the name page_url to match the helper for consistency:
|
|
// jscs:disable requireCamelCaseOrUpperCaseIdentifiers
|
|
var logging = require('../logging'),
|
|
i18n = require('../i18n'),
|
|
getPaginatedUrl = require('../data/meta/paginated_url'),
|
|
page_url,
|
|
pageUrl;
|
|
|
|
page_url = function (page, options) {
|
|
if (!options) {
|
|
options = page;
|
|
page = 1;
|
|
}
|
|
return getPaginatedUrl(page, options.data.root);
|
|
};
|
|
|
|
// ### Page URL Helper: DEPRECATED
|
|
//
|
|
// *Usage example:*
|
|
// `{{pageUrl 2}}`
|
|
//
|
|
// Returns the URL for the page specified in the current object
|
|
// context. This helper is deprecated and will be removed in future versions.
|
|
//
|
|
pageUrl = function (pageNum, options) {
|
|
logging.warn(i18n.t('warnings.helpers.page_url.isDeprecated'));
|
|
|
|
/*jshint unused:false*/
|
|
var self = this;
|
|
|
|
return page_url.call(self, pageNum, options);
|
|
};
|
|
|
|
module.exports = page_url;
|
|
module.exports.deprecated = pageUrl;
|