Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity
ghost/test/utils/fixtures/themes
History
Rish cb43a8e3a8 Updated fixture for test theme to use @site 
no refs
refs b56e684258

The test theme fixture was using old `@blog`  helper which was deprecated in v2 and replaced with `@site`. Since the latest bump to Gscan - b56e684258 - now validates a theme by going through nested `*.hbs` files, this was missed so far as it didn't fail the tests. This commit updates the test theme fixture to use updated value.
2021-03-04 01:09:54 +05:30
..
broken-theme
casper Updated links to ghost.org sites 2021-01-20 09:59:45 +13:00
casper-1.4
test-theme Updated fixture for test theme to use @site 2021-03-04 01:09:54 +05:30
test-theme-channels
casper.zip
invalid.zip
README.md Added instructions about theme fixtures maintenance 2021-03-01 19:32:20 +13:00
valid.zip Bumped gscan to 4.0.0-pre.1 2021-03-01 19:26:17 +13:00
warnings.zip

README.md

Modifying theme fixtures

When a new rule is introduced in gscan one of these fixture files might break and you'll have to update a "zip" which isn't as easy as opening a text editor... It could become that one day but for now here are some commands to help out with the edit process

  • Unzip the theme files, e.g.: cd $CURRENT_DIR && unzip valid.zip -d valid
  • Make a change in the file which caused a warning/error/whatever
  • Zip the files back: ``
  • Commit changed zip file: git add valid.zip ;... you know the drill :)

Ideas for future improvements in theme tests:

  • Decouple tests from file system as much as possible
  • Track contents of what is in "zips" in source control. Right now, having a diff on a binary file is not useful at all