0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
ghost/test/utils/fixtures
Fabien O'Carroll c5b8dab523 🐛 Fixed custom redirects for subdirectory setups
no-issue

This issue only occurs when using custom redirects with a subdirectory
setup, and the path to be redirected from is expressed as a regex, and
the url that is being redirected to is not an external url.

The issue has a few components:

- Redirect paths as a regex generally use the ^ to ensure that they
  match the beginning of the path.

- The path that the regex is matched against conditionally excludes the
  subdirectory, specifically, the subdirectory is excluded for external
  urls

These combined means you end up with a regex like /^\/custom-redirect/
and a path like /subdir/custom-redirect, these will not match/replace
correctly, and you'll end in an infinite redirect loop.

The fix here is to *always* remove the subdirectory when testing regex's
and then conditionally adding it back *only* for the redirect, and only
if it is an internal redirect
2020-06-16 10:24:13 +02:00
..
config
csv Added special handling for member import with Stripe connection 2020-06-09 23:02:38 +12:00
data 🐛 Fixed custom redirects for subdirectory setups 2020-06-16 10:24:13 +02:00
export
filter-param Updated var declarations to const/let and no lists 2020-04-29 16:51:13 +01:00
images
import
settings
themes Updated var declarations to const/let and no lists 2020-04-29 16:51:13 +01:00
data-generator.js Added ?paid query parameter to Admin API members browse endpoint (#11892) 2020-06-12 12:12:10 +01:00
test.hbs