mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-20 22:42:53 -05:00
bd9f720a70
refs: https://github.com/TryGhost/Toolbox/issues/168 - Upgraded the remaining themes to be pinned to the canary API - This required one minor fix because the edit URL has changed for authors in v4/canary - I also ripped out everywhere that the theme ghost-api version was being pinned to canary, as this was unreliable and only happening in a few places - It's also going to be unnecessary code as soon as we finish changing to only having one API version |
||
|---|---|---|
| .. | ||
| broken-theme | ||
| casper | ||
| locale-theme | ||
| members-test-theme | ||
| test-theme | ||
| test-theme-channels | ||
| casper.zip | ||
| invalid.zip | ||
| README.md | ||
| valid.zip | ||
| warnings.zip | ||
Modifying theme fixtures
When a new rule is introduced in gscan one of these fixture files might break and you'll have to update a "zip" which isn't as easy as opening a text editor... It could become that one day but for now here are some commands to help out with the edit process
- Unzip the theme files, e.g.:
cd $CURRENT_DIR && unzip valid.zip -d valid - Make a change in the file which caused a warning/error/whatever
- Zip the files back:
zip -r valid.zip ./valid - Commit changed zip file:
git add valid.zip ;... you know the drill :)
Ideas for future improvements in theme tests:
- Decouple tests from file system as much as possible
- Track contents of what is in "zips" in source control. Right now, having a diff on a binary file is not useful at all