mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-06 22:40:14 -05:00
bd9f6bb216
closes https://linear.app/ghost/issue/PLG-302 - switching from `onClick` to `onMouseDown` allows the button events to fire and be picked up by the popup-opening handler before the click causes a blur event on the main form to fire which removes the expertise buttons - we have a test for adding expertise via the main form which was giving us a false positive due to the way Playwright handles events, unfortunately I couldn't find a way to adjust that to match the real-world behaviour without ending up with a test that always fails |
||
---|---|---|
.. | ||
src | ||
test | ||
.env | ||
.eslintrc.js | ||
.yarnrc | ||
LICENSE | ||
package.json | ||
playwright.config.ts | ||
postcss.config.cjs | ||
README.md | ||
tailwind.config.js | ||
tsconfig.json | ||
tsconfig.node.json | ||
vite.config.ts |
Comments UI
Comments widget that is embedded at the bottom of posts in Ghost.
Development
Pre-requisites
- Run
yarn
in Ghost monorepo root
Running via Ghost yarn dev
in root folder
You can automatically start the comments dev server when developing Ghost by running Ghost (in root folder) via yarn dev --all
or yarn dev --comments
. This will host the comments JavaScript files, and makes sure that Ghost uses these locally hosted assets instead of the ones from the CDN.
Release
A patch release can be rolled out instantly in production, whereas a minor/major release requires the Ghost monorepo to be updated and released. In either case, you need sufficient permissions to release @tryghost
packages on NPM.
Patch release
- Run
yarn ship
and select a patch version when prompted - (Optional) Clear JsDelivr cache to get the new version out instantly (docs). Typically, you'll need to open
https://purge.jsdelivr.net/ghost/comments-ui@~${COMMENTS_UI_VERSION}/umd/comments-ui.min.js
andhttps://purge.jsdelivr.net/ghost/comments-ui@~${COMMENTS_UI_VERSION}/umd/main.css
in your browser, whereCOMMENTS_UI_VERSION
is the latest minor version inghost/core/core/shared/config/defaults.json
(code)
Minor / major release
- Run
yarn ship
and select a minor or major version when prompted - Update the Comments UI version in
ghost/core/core/shared/config/defaults.json
to the new minor or major version (code) - Wait until a new version of Ghost is released
Copyright & License
Copyright (c) 2013-2024 Ghost Foundation - Released under the MIT license.