0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
ghost/core/server/services/routing/CollectionRouter.js
Katharina Irrgang b392d1925a
Dynamic Routing Beta (#9596)
refs #9601

### Dynamic Routing

This is the beta version of dynamic routing. 

- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation 
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
  - yaml file + validation
  - routing + routers
  - url service
  - sitemaps
  - url access
- deeper implementation of yaml validations
  - e.g. hard require slashes
- ensure routing hierarchy/order
  - e.g. you enable the subscriber app
  - you have a custom static page, which lives under the same slug /subscribe
  - static pages are stronger than apps
  - e.g. the first collection owns the post it has filtered
  - a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
  - e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
  - and you change the permalink in the admin to dated permalink
  - the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
  - unmount without server restart, yey
- ensure we are backwards compatible
  - e.g. render home.hbs for collection index if collection route is /
  - ensure you can access your configured permalink from the settings table with {globals.permalink}

### Render 503 if url service did not finish

- return 503 if the url service has not finished generating the resource urls

### Rewrite sitemaps

- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
  - the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)

### Re-work usage of Url utility

- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
  - only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 19:02:20 +02:00

157 lines
5.3 KiB
JavaScript

const debug = require('ghost-ignition').debug('services:routing:collection-router');
const common = require('../../lib/common');
const settingsCache = require('../settings/cache');
const urlService = require('../url');
const ParentRouter = require('./ParentRouter');
const controllers = require('./controllers');
const middlewares = require('./middlewares');
const RSSRouter = require('./RSSRouter');
class CollectionRouter extends ParentRouter {
constructor(indexRoute, object) {
super('CollectionRouter');
// NOTE: index/parent route e.g. /, /podcast/, /magic/ ;)
this.route = {
value: indexRoute
};
this.permalinks = {
originalValue: object.permalink,
value: object.permalink
};
this.templates = object.template || [];
this.filter = object.filter || 'page:false';
/**
* @deprecated Remove in Ghost 2.0
*/
if (this.permalinks.originalValue.match(/globals\.permalinks/)) {
this.permalinks.originalValue = this.permalinks.originalValue.replace('{globals.permalinks}', '{settings.permalinks}');
this.permalinks.value = this.permalinks.originalValue.replace('{settings.permalinks}', settingsCache.get('permalinks'));
this.permalinks.value = urlService.utils.deduplicateDoubleSlashes(this.permalinks.value);
}
this.permalinks.getValue = (options) => {
options = options || {};
// @NOTE: url options are only required when registering urls in express.
// e.g. the UrlService will access the routes and doesn't want to know about possible url options
if (options.withUrlOptions) {
return urlService.utils.urlJoin(this.permalinks.value, '/:options(edit)?/');
}
return this.permalinks.value;
};
debug(this.route, this.permalinks);
this._registerRoutes();
this._listeners();
}
_registerRoutes() {
// REGISTER: context middleware for this collection
this.router().use(this._prepareIndexContext.bind(this));
// REGISTER: collection route e.g. /, /podcast/
this.mountRoute(this.route.value, controllers.collection);
// REGISTER: enable pagination by default
this.router().param('page', middlewares.pageParam);
this.mountRoute(urlService.utils.urlJoin(this.route.value, 'page', ':page(\\d+)'), controllers.collection);
this.rssRouter = new RSSRouter();
// REGISTER: enable rss by default
this.mountRouter(this.route.value, this.rssRouter.router());
// REGISTER: context middleware for entries
this.router().use(this._prepareEntryContext.bind(this));
// REGISTER: permalinks e.g. /:slug/, /podcast/:slug
this.mountRoute(this.permalinks.getValue({withUrlOptions: true}), controllers.entry);
common.events.emit('router.created', this);
}
/**
* We attach context information of the router to the request.
* By this we can e.g. access the router options in controllers.
*
* @TODO: Why do we need two context objects? O_O - refactor this out
*/
_prepareIndexContext(req, res, next) {
res.locals.routerOptions = {
filter: this.filter,
permalinks: this.permalinks.getValue({withUrlOptions: true}),
type: this.getType(),
context: ['home'],
frontPageTemplate: 'home',
templates: this.templates.reverse(),
identifier: this.identifier
};
res._route = {
type: 'collection'
};
next();
}
_prepareEntryContext(req, res, next) {
res.locals.routerOptions.context = ['post'];
res._route.type = 'entry';
next();
}
_listeners() {
/**
* @deprecated Remove in Ghost 2.0
*/
if (this.getPermalinks() && this.getPermalinks().originalValue.match(/settings\.permalinks/)) {
this._onPermalinksEditedListener = this._onPermalinksEdited.bind(this);
common.events.on('settings.permalinks.edited', this._onPermalinksEditedListener);
}
}
/**
* We unmount and mount the permalink url. This enables the ability to change urls on runtime.
*/
_onPermalinksEdited() {
this.unmountRoute(this.permalinks.getValue({withUrlOptions: true}));
this.permalinks.value = this.permalinks.originalValue.replace('{settings.permalinks}', settingsCache.get('permalinks'));
this.permalinks.value = urlService.utils.deduplicateDoubleSlashes(this.permalinks.value);
this.mountRoute(this.permalinks.getValue({withUrlOptions: true}), controllers.entry);
this.emit('updated');
}
getType() {
return 'posts';
}
getRoute(options) {
options = options || {};
return urlService.utils.createUrl(this.route.value, options.absolute, options.secure);
}
getRssUrl(options) {
return urlService.utils.createUrl(urlService.utils.urlJoin(this.route.value, this.rssRouter.route.value), options.absolute, options.secure);
}
reset() {
if (!this._onPermalinksEditedListener) {
return;
}
common.events.removeListener('settings.permalinks.edited', this._onPermalinksEditedListener);
}
}
module.exports = CollectionRouter;