0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
ghost/test/unit/services
Kevin Ansfield afbe0c27fb
🐛 Fixed __GHOST_URL__ appearing in sitemaps (#12787)
closes https://github.com/TryGhost/Team/issues/552

Refactors URL transforms so they take place at the model layer rather than the API serializer layer. Continuation of the pattern created for the settings model in https://github.com/TryGhost/Ghost/pull/12738

- Added checks to all front-end tests to ensure output does not contain the magic replacement string
  - includes failing acceptance test for `__GHOST_URL__` appearing in sitemaps
- Removed all transform-ready URL transforms from API serializers
  - input serializers transform image urls relative->absolute to keep absolute-urls as the consistent "outside of the database" format
  - output serializers should not need to perform any URL transforms as that will be done at the model layer
- Added url transforms to models layer
  - removes knowledge from the API serializers which shouldn't need to know how data is stored internally in the database
  - makes absolute urls the consistent "outside of the database" URL format
  - adds transform step to the sitemap generator because the data used for that is fetched directly via knex which will not run through the bookshelf `parse()` methods
2021-03-18 17:16:37 +00:00
..
apps
auth Removed global.Promise override (#12182) 2020-11-04 10:55:47 +00:00
mail Fixed "no-shadow" eslint warning in tests 2020-10-19 17:45:26 +13:00
members 🏗 Flattened members subscriptions data in API (#12581) 2021-02-02 16:12:53 +00:00
permissions Fixed "no-shadow" eslint warning in tests 2020-10-19 17:45:26 +13:00
routing Fixed "no-shadow" eslint warning in tests 2020-10-19 17:45:26 +13:00
rss 🐛 Fixed __GHOST_URL__ appearing in sitemaps (#12787) 2021-03-18 17:16:37 +00:00
settings Fixed cache test suite 2021-03-04 18:35:02 +13:00
themes Fixed circular dependency warning for the proxy service (#12746) 2021-03-11 16:30:49 +00:00
url Moved core/server/lib/common/logging to core/shared/logging (#11857) 2020-05-28 19:30:23 +01:00
labs_spec.js Hardcoded labs to always return members:true 2021-02-17 19:55:16 +13:00
slack_spec.js Refactored usage of the pre v4 "slack" setting 2021-02-15 15:25:54 +13:00
xmlrpc_spec.js Split the "Too many requests" error in ping service 2021-02-17 13:18:45 +13:00