0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
ghost/core/frontend/services/routing/helpers
Hannah Wolfe 623c65c509 💡Changed static router - throw 400 for missing tpl
fixes #10990

- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'

Assume you have a route.yaml file something like:

```
routes:
  /: home
```

- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-09-06 15:41:42 +01:00
..
context.js 🔥 Removed RSS pagination (#11069) 2019-09-02 11:34:13 +01:00
entry-lookup.js Extracted frontend folder (#10780) 2019-06-19 11:30:28 +02:00
error.js Extracted frontend folder (#10780) 2019-06-19 11:30:28 +02:00
fetch-data.js Added /frontend folder to default lint command 2019-08-08 10:47:13 +02:00
format-response.js Extracted frontend folder (#10780) 2019-06-19 11:30:28 +02:00
index.js Extracted frontend folder (#10780) 2019-06-19 11:30:28 +02:00
render-entries.js Extracted frontend folder (#10780) 2019-06-19 11:30:28 +02:00
render-entry.js Extracted frontend folder (#10780) 2019-06-19 11:30:28 +02:00
renderer.js Extracted frontend folder (#10780) 2019-06-19 11:30:28 +02:00
secure.js Extracted frontend folder (#10780) 2019-06-19 11:30:28 +02:00
templates.js 💡Changed static router - throw 400 for missing tpl 2019-09-06 15:41:42 +01:00