mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-03 23:00:14 -05:00
b392d1925a
refs #9601 ### Dynamic Routing This is the beta version of dynamic routing. - we had a initial implementation of "channels" available in the codebase - we have removed and moved this implementation - there is now a centralised place for dynamic routing - server/services/routing - each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts - keep as much as possible logic of routing helpers, middlewares and controllers - ensure test coverage - connect all the things together - yaml file + validation - routing + routers - url service - sitemaps - url access - deeper implementation of yaml validations - e.g. hard require slashes - ensure routing hierarchy/order - e.g. you enable the subscriber app - you have a custom static page, which lives under the same slug /subscribe - static pages are stronger than apps - e.g. the first collection owns the post it has filtered - a post cannot live in two collections - ensure apps are still working and hook into the routers layer (or better said: and register in the routing service) - put as much as possible comments to the code base for better understanding - ensure a clean debug log - ensure we can unmount routes - e.g. you have a collection permalink of /:slug/ represented by {globals.permalink} - and you change the permalink in the admin to dated permalink - the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/ - unmount without server restart, yey - ensure we are backwards compatible - e.g. render home.hbs for collection index if collection route is / - ensure you can access your configured permalink from the settings table with {globals.permalink} ### Render 503 if url service did not finish - return 503 if the url service has not finished generating the resource urls ### Rewrite sitemaps - we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime - we generate all urls on bootstrap - the sitemaps service will consume created resource and router urls - these urls will be shown on the xml pages - we listen on url events - we listen on router events - we no longer have to fetch the resources, which is nice - the urlservice pre-fetches resources and emits their urls - the urlservice is the only component who knows which urls are valid - i made some ES6 adaptions - we keep the caching logic -> only regenerate xml if there is a change - updated tests - checked test coverage (100%) ### Re-work usage of Url utility - replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId` - only for resources e.g. post, author, tag - this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime - adapt url utility - adapt tests
59 lines
2.3 KiB
JavaScript
59 lines
2.3 KiB
JavaScript
var urlService = require('../services/url'),
|
|
filters = require('../filters'),
|
|
handleError = require('./frontend/error'),
|
|
postLookup = require('./frontend/post-lookup'),
|
|
renderEntry = require('./frontend/render-entry'),
|
|
setRequestIsSecure = require('./frontend/secure');
|
|
|
|
// This here is a controller.
|
|
// It renders entries = individual posts or pages
|
|
// The "route" is handled in site/routes.js
|
|
module.exports = function entryController(req, res, next) {
|
|
// Note: this is super similar to the config middleware used in channels
|
|
// @TODO refactor into to something explicit
|
|
res._route = {
|
|
type: 'entry'
|
|
};
|
|
|
|
// Query database to find post
|
|
return postLookup(req.path).then(function then(lookup) {
|
|
// Format data 1
|
|
var post = lookup ? lookup.post : false;
|
|
|
|
if (!post) {
|
|
return next();
|
|
}
|
|
|
|
// CASE: postlookup can detect options for example /edit, unknown options get ignored and end in 404
|
|
if (lookup.isUnknownOption) {
|
|
return next();
|
|
}
|
|
|
|
// CASE: last param is of url is /edit, redirect to admin
|
|
if (lookup.isEditURL) {
|
|
return urlService.utils.redirectToAdmin(302, res, '/editor/' + post.id);
|
|
}
|
|
|
|
//
|
|
/**
|
|
* CASE: Permalink is not valid anymore, we redirect him permanently to the correct one
|
|
* This usually only happens if you switch to date permalinks or if you have date permalinks
|
|
* enabled and the published date changes.
|
|
*
|
|
* @NOTE
|
|
*
|
|
* The resource url (post.url) always contains the subdirectory. This was different before dynamic routing.
|
|
* Because with dynamic routing we have a service which knows where a resource lives - and this includes the
|
|
* subdirectory. Otherwise every time we use a resource url, we would need to take care of the subdirectory.
|
|
* That's why we have to use the original url, which contains the sub-directory.
|
|
*/
|
|
if (post.url !== req.originalUrl) {
|
|
return urlService.utils.redirect301(res, post.url);
|
|
}
|
|
|
|
setRequestIsSecure(req, post);
|
|
|
|
filters.doFilter('prePostsRender', post, res.locals)
|
|
.then(renderEntry(req, res));
|
|
}).catch(handleError(next));
|
|
};
|