mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-06 22:40:14 -05:00
a37b2cd24e
- up until this commit, git hooks were only used by a handful of people
because they were a pain:
- they'd only be set up when you did `yarn setup`
- the existing hooks ran `yarn lint` on all projects, which was
incredibly slow
- as a result, not many of us actually had them enabled, but this would
cause issues in CI because people were pushing un-linted commits
- other JS projects tend to use husky to automate the git hook setup and
lint-staged to speed up linting on changed files
- this commit switches to using them both
- `lint-staged` only runs `eslint` on staged JS files that are about to
be committed - if there's a linting error, it will stop the commit
- I've configured the pre-commit hook to successfully exit in CI because we
don't want to run pre-commit hooks right now
- this means we can remove Grunt - yay!
50 lines
1.2 KiB
Bash
Executable file
50 lines
1.2 KiB
Bash
Executable file
#!/bin/bash
|
|
# Modified from https://github.com/chaitanyagupta/gitutils
|
|
|
|
[ -n "$CI" ] && exit 0
|
|
|
|
yarn lint-staged
|
|
lintStatus=$?
|
|
|
|
if [ $lintStatus -ne 0 ]; then
|
|
echo "❌ Linting failed"
|
|
exit 1
|
|
fi
|
|
|
|
green='\033[0;32m'
|
|
no_color='\033[0m'
|
|
grey='\033[0;90m'
|
|
|
|
|
|
ROOT_DIR=$(git rev-parse --show-cdup)
|
|
SUBMODULES=$(grep path ${ROOT_DIR}.gitmodules | sed 's/^.*path = //')
|
|
MOD_SUBMODULES=$(git diff --cached --name-only | grep -F "$SUBMODULES")
|
|
|
|
echo -e "Checking submodules ${grey}(pre-commit hook)${no_color} "
|
|
|
|
# If no modified submodules, exit with status code 0, else prompt the
|
|
# user and exit accordingly
|
|
if [[ -n "$MOD_SUBMODULES" ]]; then
|
|
echo "Submodules to be committed:"
|
|
echo " (use \"git reset HEAD <file>...\" to unstage)"
|
|
echo
|
|
|
|
for SUB in $MOD_SUBMODULES
|
|
do
|
|
echo -e "\t${green}modified:\t$SUB${no_color}"
|
|
done
|
|
echo
|
|
echo -n -e "Continue with commit? ${grey}(N|y)${no_color} "
|
|
read -n 1 reply </dev/tty
|
|
echo
|
|
if [[ "$reply" == "y" || "$reply" == "Y" ]]; then
|
|
echo "Permitting submodules to be committed..."
|
|
exit 0
|
|
else
|
|
echo "Aborting commit due to submodule update."
|
|
exit 1
|
|
fi
|
|
else
|
|
echo "No submodules in commit, continuing..."
|
|
exit 0
|
|
fi
|