mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-13 22:41:32 -05:00
a1ed9adf92
Ember.ObjectController (and Ember.ArrayController) will be deprecated in Ember 1.11 (and removed from core in Ember 2.0). The reasoning is detailed in the Ember 2.0 RFC. This PR does the following: * Updates templates/controllers/views to explicitly reference model properties (instead of relying on proxying behavior). * Clearly delineate where certain properties are being set or retrieved from (for example it was not clear exactly where `scratch` and `titleScratch` were stored). * Remove usage of `Ember.ObjectController`. * Add JSCS rule to prevent future PR's from adding regressions. |
||
|---|---|---|
| .. | ||
| adapters | ||
| assets | ||
| components | ||
| controllers | ||
| docs | ||
| helpers | ||
| html | ||
| initializers | ||
| mixins | ||
| models | ||
| routes | ||
| serializers | ||
| templates | ||
| transforms | ||
| utils | ||
| validators | ||
| views | ||
| .jshintrc | ||
| _config.yml | ||
| app.js | ||
| config-dev.js | ||
| config-prod.js | ||
| loader.js | ||
| README.md | ||
| router.js | ||
Ghost Admin Client
Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.
Architecture
ToDo: Explain the basic Ember app structure.
client/
├── assets/
│ ├── ghost.css
│ └── ghost.min.css
├── things/
│ ├── things.js
│ └── things.min.js
└── things/
├── things.js
└── things.js
SASS
All CSS is written in SASS and compiled using grunt. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.
Styles are primarily broken up into 4 main categories:
- Helpers - are pure-sass files. Variables/mixins/things which are generally never compiled to actual CSS, and are simply used to aid development.
- Patterns - are base level visual styles for HTML elements (eg. Buttons)
- Components - are groups of patterns used to create a UI component (eg. Modals)
- Layouts - are groups of components used to create application screens (eg. Settings)
- Lib - is where we store styles for 3rd party components.
All of these separate files are subsequently imported and compiled in screen.scss.
Front End Standards
- 4 spaces for HTML & CSS indentation. Never tabs.
- Double quotes only, never single quotes.
- Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
- Adhere to the Recess CSS property order.
- Always a space after a property's colon (.e.g, display: block; and not display:block;).
- End all lines with a semi-colon.
- For multiple, comma-separated selectors, place each selector on its own line.
- Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
- Avoid SASS over-nesting. Never nest more than 3 levels deep.
- Use comments to explain "why" not "what" (Eg. This requires a z-index in order to appear above mobile navigation. Not: This is a thing which is always on top!)