mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-10 23:36:14 -05:00
Initial Subscribers screen
- set up mocked api endpoints
- basic subscribers screen with data loading, infinite scroll
"Add Subscriber" screen
- uses modal to display a new subscriber form
- validates subscriber e-mail address
- moves pagination from route into controller to use filtered/sorted CPs on top of a live-query so that new subscribers are added to the list and the total can be properly managed
TODO:
- there is currently a pretty serious performance issue where the whole table is re-rendered when the live-query is updated. `ember-light-table` doesn't allow for live-binding and has no options to easily manipulate it's rows using an external interface - it's possible to move the page loading into the component so we only render new rows but that leaves it difficult to react to new subscribers being added through the UI. I believe the number of components used within the table is also adding to the performance problems.
- most likely solution is to drop `ember-light-table` in favour of rendering the table directly - glimmer should do a good job of fast updates even though the underlying array will be completely swapped out
"Import subscribers" screen
- uses modal to display an import subscribers CSV file upload form
- displays upload progress
- displays import stats and reloads subscribers table once import has completed
- adds `gh-file-uploader` component (NB. pared down copy of `gh-image-uploader`, ripe for some refactoring)
- fixes subscribers acceptance test failing because fixtures did not have the labs flag enabled
Unfortunately this doesn't have 100% test coverage as we're limited in how we can simulate file uploads 😞
Fix performance issues with subscribers table
- moves the table definition from the component up to the controller
- switches back to manually manipulating table rows instead of using a live-query
This is a quick-fix in that it allows us to continue using the `ember-light-table` component but it does mean that we lose some flexibility that the live-query gave us. For now it's not much of an issue and it allows us to defer deeper performance/flexibility work until we have a concrete need and requirements.
Hook up Export CSV button
- use a hidden iFrame to trigger the browser to hit the CSV export endpoint and download the file
Re-order subscribers table by clicking column headers
- displays currently sorted column and sort direction
- clicking a column header re-fetches the data from the server with the appropriate query params
Fix scroll triggers for infinite pagination + icon change
- adds a debounce as well as the throttle so that we always get a final scroll trigger once scrolling has stopped
- changes the subscribers icon from the temporary team icon to the mail icon
118 lines
3.5 KiB
JavaScript
118 lines
3.5 KiB
JavaScript
import Ember from 'ember';
|
|
import getRequestErrorMessage from 'ghost/utils/ajax';
|
|
|
|
const {
|
|
Mixin,
|
|
computed,
|
|
RSVP,
|
|
inject: {service}
|
|
} = Ember;
|
|
|
|
let defaultPaginationSettings = {
|
|
page: 1,
|
|
limit: 15
|
|
};
|
|
|
|
export default Mixin.create({
|
|
notifications: service(),
|
|
|
|
paginationModel: null,
|
|
paginationSettings: null,
|
|
|
|
// add a hook so that routes/controllers can do something with the meta data
|
|
paginationMeta: computed({
|
|
get() {
|
|
return this._paginationMeta;
|
|
},
|
|
set(key, value) {
|
|
if (this.didReceivePaginationMeta) {
|
|
this.didReceivePaginationMeta(value);
|
|
}
|
|
this._paginationMeta = value;
|
|
return value;
|
|
}
|
|
}),
|
|
|
|
init() {
|
|
let paginationSettings = this.get('paginationSettings');
|
|
let settings = Ember.assign({}, defaultPaginationSettings, paginationSettings);
|
|
|
|
this._super(...arguments);
|
|
this.set('paginationSettings', settings);
|
|
this.set('paginationMeta', {});
|
|
},
|
|
|
|
/**
|
|
* Takes an ajax response, concatenates any error messages, then generates an error notification.
|
|
* @param {jqXHR} response The jQuery ajax reponse object.
|
|
* @return
|
|
*/
|
|
reportLoadError(response) {
|
|
let message = 'A problem was encountered while loading more records';
|
|
|
|
if (response) {
|
|
// Get message from response
|
|
message += `: ${getRequestErrorMessage(response, true)}`;
|
|
} else {
|
|
message += '.';
|
|
}
|
|
|
|
this.get('notifications').showAlert(message, {type: 'error', key: 'pagination.load.failed'});
|
|
},
|
|
|
|
loadFirstPage() {
|
|
let paginationSettings = this.get('paginationSettings');
|
|
let modelName = this.get('paginationModel');
|
|
|
|
this.set('paginationSettings.page', 1);
|
|
|
|
this.set('isLoading', true);
|
|
|
|
return this.get('store').query(modelName, paginationSettings).then((results) => {
|
|
this.set('paginationMeta', results.meta);
|
|
return results;
|
|
}).catch((response) => {
|
|
this.reportLoadError(response);
|
|
}).finally(() => {
|
|
this.set('isLoading', false);
|
|
});
|
|
},
|
|
|
|
actions: {
|
|
loadFirstPage() {
|
|
return this.loadFirstPage();
|
|
},
|
|
|
|
/**
|
|
* Loads the next paginated page of posts into the ember-data store. Will cause the posts list UI to update.
|
|
* @return
|
|
*/
|
|
loadNextPage() {
|
|
let store = this.get('store');
|
|
let modelName = this.get('paginationModel');
|
|
let metadata = this.get('paginationMeta');
|
|
let nextPage = metadata.pagination && metadata.pagination.next;
|
|
let paginationSettings = this.get('paginationSettings');
|
|
|
|
if (nextPage && !this.get('isLoading')) {
|
|
this.set('isLoading', true);
|
|
this.set('paginationSettings.page', nextPage);
|
|
|
|
return store.query(modelName, paginationSettings).then((results) => {
|
|
this.set('paginationMeta', results.meta);
|
|
return results;
|
|
}).catch((response) => {
|
|
this.reportLoadError(response);
|
|
}).finally(() => {
|
|
this.set('isLoading', false);
|
|
});
|
|
} else {
|
|
return RSVP.resolve([]);
|
|
}
|
|
},
|
|
|
|
resetPagination() {
|
|
this.set('paginationSettings.page', 1);
|
|
}
|
|
}
|
|
});
|