0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-13 22:41:32 -05:00
ghost/apps/admin-x-settings
Ronald Langeveld 9ae2e24315
Fixed overwritten theme duplication in ThemeList (#18405)
refs
https://www.notion.so/ghost/AdminX-feedback-27fc7f549bbf4a53bfa2e7b6e5643963?p=6a295239a38840f18b0a3b1710095074&pm=s

- There was an issue where an overwritten theme would be included in the
themes array twice when passed to the ThemeList component.
- We now remove the initial theme from the array when overwriting to
avoid duplications.

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 1260615</samp>

This pull request refactors the theme problem view component to make it
reusable and fixes a bug with theme name display in the theme modal. It
affects the files `InvalidThemeModal.tsx` and `ThemeModal.tsx` in the
admin-x-settings app.
2023-10-02 09:50:23 +07:00
..
.storybook AdminX handling '/' in textfields vs. searchbar shortcut (#18283) 2023-09-25 14:22:10 +02:00
src Fixed overwritten theme duplication in ThemeList (#18405) 2023-10-02 09:50:23 +07:00
test Slightly improved AdminX pagination behaviour (#18331) 2023-09-25 14:09:35 +00:00
.eslintrc.cjs Temporarily fixed eslint rules being disabled in AdminX (#17565) 2023-08-02 08:37:51 +01:00
.yarnrc Prevented git tags from being created for apps 2023-07-10 13:09:28 +02:00
index.html
package.json Update dependency @tanstack/react-query to v4.35.7 2023-10-02 01:18:34 +00:00
playwright.config.ts Added recommend back URL (#18382) 2023-09-28 10:54:16 +00:00
postcss.config.cjs
README.md
tailwind.config.cjs AdminX mobile updates (#18137) 2023-09-19 12:09:38 +02:00
tsconfig.json
tsconfig.node.json
vite.config.ts Added uniqueness validation for the recommendation URL (#18163) 2023-09-15 13:14:47 +00:00

Admin X Settings

Experimental re-write of Ghost Admin Settings in React

Development

Pre-requisites

  • Run yarn in Ghost monorepo root
  • Run yarn in this directory

Running the development version

Run yarn dev to start the development server to test/develop the settings standalone. This will generate a demo site from the index.html file which renders the app and makes it available on http://localhost:5173

Running inside Admin

Run yarn dev from the top-level repo with --adminX

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test run lint and tests