0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
ghost/core/test/unit
kirrg001 449bae9a48 🐛 Fixed missing "value" property for settings Admin API v2
closes #10518

- we had a very generic logic to remove "unwanted" null values
  - copied from v0.1
  - originally added in 7d4107fec4
- this logic transformed: settings = [{key: 'key', value: null}] to [{key: 'key'}], which is wrong
- i've removed this generic logic completely, because i don't know which purpose it serves
- if there a specific case where we want to remove null values, we should either use the JSON schema or use a specific serializer for the target resource
- added tests to proof that settings API behaves as it should
- one test failed because we removed the isNull logic -> if you send published_at = null on a published post
  - the model layer has a piece of logic to force a date if you set published_at to null if the status is published
  - protected
2019-03-04 20:06:53 +01:00
..
adapters Removed superagent dependency (#10535) 2019-03-04 15:59:38 +08:00
api 🐛 Fixed missing "value" property for settings Admin API v2 2019-03-04 20:06:53 +01:00
apps 🐛 Fixed empty amp page 2019-02-27 17:56:09 +01:00
config Removed old jshint/jscs rules 2018-06-02 21:48:23 +02:00
data Added members permission migrations 2019-02-26 15:43:36 +07:00
helpers 🐛 Supported "false" as absolute attribute value (#10556) 2019-03-04 11:23:42 +01:00
lib Updated mobiledoc renderer to insert begin/end HTML comments around cards 2019-02-25 18:05:01 +07:00
models Separated pages & posts in Admin API v2 (#10494) 2019-02-22 10:17:14 +07:00
public Refactored Ghost SDK unit test 2018-10-05 16:49:46 +02:00
services 🐛 Allowed data in collections to use specified key (#10559) 2019-03-04 17:53:58 +01:00
web Bumped sinon from 4.4.6 to 7.3.2 (#10400) 2019-01-21 17:53:44 +01:00
filters_spec.js Bumped sinon from 4.4.6 to 7.3.2 (#10400) 2019-01-21 17:53:44 +01:00