mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-06 22:40:14 -05:00
37a22edbe9
- cache-control had some logic in it for private blogging + similar logic exists for members in site/app
- having it in 2 places is weird, and having it inside the mw makes the mw less generic/reusable
- instead of requiring config inside the middleware, we pass config in for the one case where this is used
- fixed tests that didn't test anything 🙈
83 lines
2.9 KiB
JavaScript
83 lines
2.9 KiB
JavaScript
var should = require('should'),
|
|
sinon = require('sinon'),
|
|
cacheControl = require('../../../../core/server/web/shared/middlewares/cache-control');
|
|
|
|
describe('Middleware: cacheControl', function () {
|
|
var res;
|
|
|
|
beforeEach(function () {
|
|
res = {
|
|
set: sinon.spy()
|
|
};
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
it('correctly sets the public profile headers', function (done) {
|
|
cacheControl('public')(null, res, function (a) {
|
|
should.not.exist(a);
|
|
res.set.calledOnce.should.be.true();
|
|
res.set.calledWith({'Cache-Control': 'public, max-age=0'}).should.be.true();
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('correctly sets the public profile headers with custom maxAge', function (done) {
|
|
cacheControl('public', {maxAge: 123456})(null, res, function (a) {
|
|
should.not.exist(a);
|
|
res.set.calledOnce.should.be.true();
|
|
res.set.calledWith({'Cache-Control': 'public, max-age=123456'}).should.be.true();
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('correctly sets the private profile headers', function (done) {
|
|
cacheControl('private')(null, res, function (a) {
|
|
should.not.exist(a);
|
|
res.set.calledOnce.should.be.true();
|
|
res.set.calledWith({
|
|
'Cache-Control': 'no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0'
|
|
}).should.be.true();
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('will not set headers without a profile', function (done) {
|
|
cacheControl()(null, res, function (a) {
|
|
should.not.exist(a);
|
|
res.set.called.should.be.false();
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('will not get confused between serving public and private', function (done) {
|
|
var publicCC = cacheControl('public'),
|
|
privateCC = cacheControl('private');
|
|
|
|
publicCC(null, res, function () {
|
|
res.set.calledOnce.should.be.true();
|
|
res.set.calledWith({'Cache-Control': 'public, max-age=0'}).should.be.true();
|
|
|
|
privateCC(null, res, function () {
|
|
res.set.calledTwice.should.be.true();
|
|
res.set.calledWith({
|
|
'Cache-Control': 'no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0'
|
|
}).should.be.true();
|
|
|
|
publicCC(null, res, function () {
|
|
res.set.calledThrice.should.be.true();
|
|
res.set.calledWith({'Cache-Control': 'public, max-age=0'});
|
|
|
|
privateCC(null, res, function () {
|
|
res.set.calledWith({
|
|
'Cache-Control': 'no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0'
|
|
}).should.be.true();
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|