0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
ghost/test/e2e-api/admin
Simon Backx 6b3a657f88
Renamed newsletter_id and email_recipient_filter options (#14798)
refs https://github.com/TryGhost/Team/issues/1596

- Renamed `newsletter_id` to `newsletter` option, the `newsletter` option expects a slug instead of an id
- Renamed `email_recipient_filter` to `email_segment` option
- Default `email_segment` to `all`. Ignored if no newsletter is set
- `email_segment` is ignored if no newsletter is set
- When reverting a post to a draft, both `newsletter` and `email_segment` are reset to their default values (null, all)
- Removed legacy mapping from old email_recipient_filter values 'paid' and 'free' (already a migration in place)
- Dropped legacy throwing errors when email_recipient_filter is paid or free in transformEmailRecipientFilter
- Reorganized transformEmailRecipientFilter parameters for the now required newsletter parameter
- Fixed an issue where the newsletter filter wasn't working because it wasn't in permittedoptions
- Fixed an issue where you could send to an archived newsletter
- Added an extra protection when scheduling to an active, and later archiving the newsletter
- Dropped support for `send_email_when_published` in API
- When importing posts we currently don't have a system in place to set the newsletter_id to map the `send_email_when_published` behaviour. Since this was already the case, I won't include a fix in this PR.
- Stripped `email_recipient_filter`/`email_segment` from Content API (https://ghost.slack.com/archives/C02G9E68C/p1652363211841359?thread_ts=1650623650.233229&cid=C02G9E68C)
- Updated `admin-api-schema` to 3.2.0, which includes the new email_segment property
- Contains a temporary fix for https://github.com/TryGhost/Team/issues/1626, where the `.related('newsletter').fetch` call fails when the newsletter relation is already loaded, because of the overridden `formatOnWrite` method.

Since the `email_recipient_filter` is no longer used without a newsletter, the `none` value is no longer used. A migration transforms all those values to `all`. This should be safe, because we only send an email now when newsletter_id is not null (scheduled posts should already have a newsletter_id, even if at the time of scheduling they didn't add the newsletter_id option, because at that time, we defaulted to the default newsletter).

Admin changes to make this work: https://github.com/TryGhost/Admin/pull/2380
2022-05-16 10:18:04 +02:00
..
__snapshots__ Renamed newsletter_id and email_recipient_filter options (#14798) 2022-05-16 10:18:04 +02:00
actions.test.js Aliased canary endpoints to point to non-versioned URLs 2022-03-14 21:22:54 +13:00
config.test.js 🐛 Fixed config API not returning boolean 2022-01-20 18:25:41 +02:00
custom-theme-settings.test.js Fixed filename casing in canary API 2022-03-24 17:25:53 +00:00
db.test.js Renamed testUtils.startGhost to localUtils.startGhost 2021-11-22 21:56:32 +13:00
email-previews.test.js Fixed email preview using wrong newsletter (#14756) 2022-05-11 17:52:24 +02:00
emails.test.js Added missing e2e emails API browse & retry tests 2022-03-28 17:32:58 +01:00
files.test.js Renamed testUtils.startGhost to localUtils.startGhost 2021-11-22 21:56:32 +13:00
images.test.js Renamed testUtils.startGhost to localUtils.startGhost 2021-11-22 21:56:32 +13:00
integrations.test.js Added serializer for integrations.destroy 2022-03-22 13:52:32 +00:00
invites.test.js Renamed testUtils.startGhost to localUtils.startGhost 2021-11-22 21:56:32 +13:00
key-authentication.test.js Fixed filename casing in canary API 2022-03-24 17:25:53 +00:00
labels.test.js Added expectEmptyBody assertions to e2e framework 2022-03-31 18:56:05 +01:00
media.test.js Renamed testUtils.startGhost to localUtils.startGhost 2021-11-22 21:56:32 +13:00
members-importer.test.js Fixed mockLabs disabling all other flags (#14621) 2022-04-28 10:55:20 +02:00
members-newsletters.test.js Fixed mockLabs disabling all other flags (#14621) 2022-04-28 10:55:20 +02:00
members-stripe-connect.test.js Added expectEmptyBody assertions to e2e framework 2022-03-31 18:56:05 +01:00
members.test.js Allowed tiers include and data for member endpoints (#14790) 2022-05-11 22:26:03 +05:30
newsletters.test.js Fixed error in newsletter editing limit checks (#14817) 2022-05-13 10:15:35 +02:00
notifications.test.js Renamed testUtils.startGhost to localUtils.startGhost 2021-11-22 21:56:32 +13:00
oembed.test.js 🐛 Fixes oembed bookmark with whitespaces 2021-12-01 15:58:09 +01:00
offers.test.js Added e2e tests for offers API (#14335) 2022-03-24 13:41:48 +01:00
pages.test.js Replaced Products with Tiers API endpoints 2022-05-12 19:59:57 +01:00
posts.test.js Renamed newsletter_id and email_recipient_filter options (#14798) 2022-05-16 10:18:04 +02:00
redirects.test.js Added serializer for redirects.upload 2022-03-22 13:52:32 +00:00
roles.test.js Renamed testUtils.startGhost to localUtils.startGhost 2021-11-22 21:56:32 +13:00
session.test.js Swapped etag matcher to always be anyEtag 2022-05-02 11:05:07 +01:00
settings-files.test.js Added serializer for missing settings endpoints 2022-03-22 13:52:32 +00:00
settings.test.js Removed GET settings/:key route 2022-05-13 23:18:53 +01:00
site.test.js Swapped etag matcher to always be anyEtag 2022-05-02 11:05:07 +01:00
slugs.test.js Renamed testUtils.startGhost to localUtils.startGhost 2021-11-22 21:56:32 +13:00
snippets.test.js Added expectEmptyBody assertions to e2e framework 2022-03-31 18:56:05 +01:00
stats.test.js Added /stats/subscriptions API (#14547) 2022-04-27 14:53:32 +01:00
tags.test.js Renamed testUtils.startGhost to localUtils.startGhost 2021-11-22 21:56:32 +13:00
themes.test.js Added serializer for themes.destroy 2022-03-22 13:52:32 +00:00
tiers.test.js Fixed mockLabs disabling all other flags (#14621) 2022-04-28 10:55:20 +02:00
users.test.js Fixed test query using outdated author_id filter 2022-05-09 20:34:06 +08:00
utils.js Renamed newsletter_id and email_recipient_filter options (#14798) 2022-05-16 10:18:04 +02:00
webhooks.test.js Changed webhooks to store safe version 2022-05-06 12:43:14 +01:00