mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-27 22:49:56 -05:00
22e13acd65
- All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!
327 lines
11 KiB
JavaScript
327 lines
11 KiB
JavaScript
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const Promise = require('bluebird');
|
|
const testUtils = require('../../../../utils');
|
|
const api = require('../../../../../core/server/api');
|
|
const helpers = require('../../../../../core/frontend/services/routing/helpers');
|
|
|
|
describe('Unit - services/routing/helpers/entry-lookup', function () {
|
|
let posts;
|
|
let locals;
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
describe('v2', function () {
|
|
describe('static pages', function () {
|
|
const routerOptions = {
|
|
permalinks: '/:slug/',
|
|
query: {controller: 'pagesPublic', resource: 'pages'}
|
|
};
|
|
|
|
let pages;
|
|
let postsReadStub;
|
|
let pagesReadStub;
|
|
|
|
beforeEach(function () {
|
|
pages = [
|
|
testUtils.DataGenerator.forKnex.createPost({url: '/test/', slug: 'test', page: true})
|
|
];
|
|
|
|
postsReadStub = sinon.stub();
|
|
pagesReadStub = sinon.stub();
|
|
|
|
pagesReadStub//.withArgs({slug: pages[0].slug, include: 'author,authors,tags'})
|
|
.resolves({
|
|
pages: pages
|
|
});
|
|
|
|
sinon.stub(api.v2, 'posts').get(() => {
|
|
return {
|
|
read: postsReadStub
|
|
};
|
|
});
|
|
|
|
sinon.stub(api.v2, 'pagesPublic').get(() => {
|
|
return {
|
|
read: pagesReadStub
|
|
};
|
|
});
|
|
|
|
locals = {apiVersion: 'v2'};
|
|
});
|
|
|
|
it('ensure pages controller is triggered', function () {
|
|
const testUrl = 'http://127.0.0.1:2369' + pages[0].url;
|
|
|
|
return helpers.entryLookup(testUrl, routerOptions, locals).then(function (lookup) {
|
|
postsReadStub.called.should.be.false();
|
|
pagesReadStub.calledOnce.should.be.true();
|
|
should.exist(lookup.entry);
|
|
lookup.entry.should.have.property('url', pages[0].url);
|
|
lookup.isEditURL.should.be.false();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('posts', function () {
|
|
const routerOptions = {
|
|
permalinks: '/:slug/',
|
|
query: {controller: 'posts', resource: 'posts'}
|
|
};
|
|
|
|
let posts;
|
|
let postsReadStub;
|
|
let pagesReadStub;
|
|
|
|
beforeEach(function () {
|
|
posts = [
|
|
testUtils.DataGenerator.forKnex.createPost({url: '/test/', slug: 'test'})
|
|
];
|
|
|
|
postsReadStub = sinon.stub();
|
|
pagesReadStub = sinon.stub();
|
|
|
|
postsReadStub//.withArgs({slug: posts[0].slug, include: 'author,authors,tags'})
|
|
.resolves({
|
|
posts: posts
|
|
});
|
|
|
|
sinon.stub(api.v2, 'posts').get(() => {
|
|
return {
|
|
read: postsReadStub
|
|
};
|
|
});
|
|
|
|
sinon.stub(api.v2, 'pagesPublic').get(() => {
|
|
return {
|
|
read: pagesReadStub
|
|
};
|
|
});
|
|
|
|
locals = {apiVersion: 'v2'};
|
|
});
|
|
|
|
it('ensure posts controller is triggered', function () {
|
|
const testUrl = 'http://127.0.0.1:2369' + posts[0].url;
|
|
|
|
return helpers.entryLookup(testUrl, routerOptions, locals).then(function (lookup) {
|
|
postsReadStub.calledOnce.should.be.true();
|
|
pagesReadStub.called.should.be.false();
|
|
should.exist(lookup.entry);
|
|
lookup.entry.should.have.property('url', posts[0].url);
|
|
lookup.isEditURL.should.be.false();
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('canary', function () {
|
|
describe('static pages', function () {
|
|
const routerOptions = {
|
|
permalinks: '/:slug/',
|
|
query: {controller: 'pagesPublic', resource: 'pages'}
|
|
};
|
|
|
|
let pages;
|
|
let postsReadStub;
|
|
let pagesReadStub;
|
|
|
|
beforeEach(function () {
|
|
pages = [
|
|
testUtils.DataGenerator.forKnex.createPost({url: '/test/', slug: 'test', page: true})
|
|
];
|
|
|
|
postsReadStub = sinon.stub();
|
|
pagesReadStub = sinon.stub();
|
|
|
|
pagesReadStub//.withArgs({slug: pages[0].slug, include: 'author,authors,tags'})
|
|
.resolves({
|
|
pages: pages
|
|
});
|
|
|
|
sinon.stub(api.canary, 'posts').get(() => {
|
|
return {
|
|
read: postsReadStub
|
|
};
|
|
});
|
|
|
|
sinon.stub(api.canary, 'pagesPublic').get(() => {
|
|
return {
|
|
read: pagesReadStub
|
|
};
|
|
});
|
|
|
|
locals = {apiVersion: 'canary'};
|
|
});
|
|
|
|
it('ensure pages controller is triggered', function () {
|
|
const testUrl = 'http://127.0.0.1:2369' + pages[0].url;
|
|
|
|
return helpers.entryLookup(testUrl, routerOptions, locals).then(function (lookup) {
|
|
postsReadStub.called.should.be.false();
|
|
pagesReadStub.calledOnce.should.be.true();
|
|
should.exist(lookup.entry);
|
|
lookup.entry.should.have.property('url', pages[0].url);
|
|
lookup.isEditURL.should.be.false();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('posts', function () {
|
|
const routerOptions = {
|
|
permalinks: '/:slug/',
|
|
query: {controller: 'posts', resource: 'posts'}
|
|
};
|
|
|
|
let posts;
|
|
let postsReadStub;
|
|
let pagesReadStub;
|
|
|
|
beforeEach(function () {
|
|
posts = [
|
|
testUtils.DataGenerator.forKnex.createPost({url: '/test/', slug: 'test'})
|
|
];
|
|
|
|
postsReadStub = sinon.stub();
|
|
pagesReadStub = sinon.stub();
|
|
|
|
postsReadStub//.withArgs({slug: posts[0].slug, include: 'author,authors,tags'})
|
|
.resolves({
|
|
posts: posts
|
|
});
|
|
|
|
sinon.stub(api.canary, 'posts').get(() => {
|
|
return {
|
|
read: postsReadStub
|
|
};
|
|
});
|
|
|
|
sinon.stub(api.canary, 'pagesPublic').get(() => {
|
|
return {
|
|
read: pagesReadStub
|
|
};
|
|
});
|
|
|
|
locals = {apiVersion: 'canary'};
|
|
});
|
|
|
|
it('ensure posts controller is triggered', function () {
|
|
const testUrl = 'http://127.0.0.1:2369' + posts[0].url;
|
|
|
|
return helpers.entryLookup(testUrl, routerOptions, locals).then(function (lookup) {
|
|
postsReadStub.calledOnce.should.be.true();
|
|
pagesReadStub.called.should.be.false();
|
|
should.exist(lookup.entry);
|
|
lookup.entry.should.have.property('url', posts[0].url);
|
|
lookup.isEditURL.should.be.false();
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('v3', function () {
|
|
describe('static pages', function () {
|
|
const routerOptions = {
|
|
permalinks: '/:slug/',
|
|
query: {controller: 'pagesPublic', resource: 'pages'}
|
|
};
|
|
|
|
let pages;
|
|
let postsReadStub;
|
|
let pagesReadStub;
|
|
|
|
beforeEach(function () {
|
|
pages = [
|
|
testUtils.DataGenerator.forKnex.createPost({url: '/test/', slug: 'test', page: true})
|
|
];
|
|
|
|
postsReadStub = sinon.stub();
|
|
pagesReadStub = sinon.stub();
|
|
|
|
pagesReadStub//.withArgs({slug: pages[0].slug, include: 'author,authors,tags'})
|
|
.resolves({
|
|
pages: pages
|
|
});
|
|
|
|
sinon.stub(api.v3, 'posts').get(() => {
|
|
return {
|
|
read: postsReadStub
|
|
};
|
|
});
|
|
|
|
sinon.stub(api.v3, 'pagesPublic').get(() => {
|
|
return {
|
|
read: pagesReadStub
|
|
};
|
|
});
|
|
|
|
locals = {apiVersion: 'v3'};
|
|
});
|
|
|
|
it('ensure pages controller is triggered', function () {
|
|
const testUrl = 'http://127.0.0.1:2369' + pages[0].url;
|
|
|
|
return helpers.entryLookup(testUrl, routerOptions, locals).then(function (lookup) {
|
|
postsReadStub.called.should.be.false();
|
|
pagesReadStub.calledOnce.should.be.true();
|
|
should.exist(lookup.entry);
|
|
lookup.entry.should.have.property('url', pages[0].url);
|
|
lookup.isEditURL.should.be.false();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('posts', function () {
|
|
const routerOptions = {
|
|
permalinks: '/:slug/',
|
|
query: {controller: 'posts', resource: 'posts'}
|
|
};
|
|
|
|
let posts;
|
|
let postsReadStub;
|
|
let pagesReadStub;
|
|
|
|
beforeEach(function () {
|
|
posts = [
|
|
testUtils.DataGenerator.forKnex.createPost({url: '/test/', slug: 'test'})
|
|
];
|
|
|
|
postsReadStub = sinon.stub();
|
|
pagesReadStub = sinon.stub();
|
|
|
|
postsReadStub//.withArgs({slug: posts[0].slug, include: 'author,authors,tags'})
|
|
.resolves({
|
|
posts: posts
|
|
});
|
|
|
|
sinon.stub(api.v3, 'posts').get(() => {
|
|
return {
|
|
read: postsReadStub
|
|
};
|
|
});
|
|
|
|
sinon.stub(api.v3, 'pagesPublic').get(() => {
|
|
return {
|
|
read: pagesReadStub
|
|
};
|
|
});
|
|
|
|
locals = {apiVersion: 'v3'};
|
|
});
|
|
|
|
it('ensure posts controller is triggered', function () {
|
|
const testUrl = 'http://127.0.0.1:2369' + posts[0].url;
|
|
|
|
return helpers.entryLookup(testUrl, routerOptions, locals).then(function (lookup) {
|
|
postsReadStub.calledOnce.should.be.true();
|
|
pagesReadStub.called.should.be.false();
|
|
should.exist(lookup.entry);
|
|
lookup.entry.should.have.property('url', posts[0].url);
|
|
lookup.isEditURL.should.be.false();
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|