0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
ghost/test/unit/services/theme-engine/middleware.test.js
Kevin Ansfield 8a17e723a1 Moved usage of preview options from globalTemplateOptions to localTemplateOptions
refs https://github.com/TryGhost/Team/issues/1097

globalTemplateOptions are supposed to be static with localTemplateOptions being merged in per-request, however the per-request preview data was being extracted and set in the global options. Comments suggest that the global data should be static and eventually updated via other means, the usage of the request object to get per-request preview data is working against that.

- adjusted the preview handler to return an object rather than changing properties by reference on a passed in object
- moved preview data fetching out of `getSiteData()` used in `updateGlobalTemplateOptions()` and into `updateLocalTemplateOptions()` so that we're not relying on the request object in `updateGlobalTemplateOptions()`
2021-09-30 12:12:55 +01:00

253 lines
8.3 KiB
JavaScript

const should = require('should');
const sinon = require('sinon');
const hbs = require('../../../../core/frontend/services/theme-engine/engine');
const middleware = require('../../../../core/frontend/services/theme-engine').middleware;
// is only exposed via themeEngine.getActive()
const activeTheme = require('../../../../core/frontend/services/theme-engine/active');
const settingsCache = require('../../../../core/shared/settings-cache');
const sandbox = sinon.createSandbox();
function executeMiddleware(toExecute, req, res, next) {
const [current, ...rest] = toExecute;
current(req, res, function (err) {
if (err) {
return next(err);
}
if (!rest.length) {
return next();
}
return executeMiddleware(rest, req, res, next);
});
}
describe('Themes middleware', function () {
afterEach(function () {
sandbox.restore();
});
let req;
let res;
let fakeActiveTheme;
let fakeActiveThemeName;
let fakeSiteData;
let fakeLabsData;
beforeEach(function () {
req = {app: {}, header: () => {}};
res = {locals: {}};
fakeActiveTheme = {
config: sandbox.stub().returns(2),
mount: sandbox.stub()
};
fakeActiveThemeName = 'bacon-sensation';
fakeSiteData = {};
fakeLabsData = {
// labs data is deep cloned,
// if we want to compare it
// we will need some unique content
members: true
};
sandbox.stub(activeTheme, 'get')
.returns(fakeActiveTheme);
sandbox.stub(settingsCache, 'get')
.withArgs('labs').returns(fakeLabsData)
.withArgs('active_theme').returns(fakeActiveThemeName);
sandbox.stub(settingsCache, 'getPublic')
.returns(fakeSiteData);
sandbox.stub(hbs, 'updateTemplateOptions');
sandbox.stub(hbs, 'updateLocalTemplateOptions');
});
it('mounts active theme if not yet mounted', function (done) {
fakeActiveTheme.mounted = false;
executeMiddleware(middleware, req, res, function next(err) {
try {
should.not.exist(err);
fakeActiveTheme.mount.called.should.be.true();
fakeActiveTheme.mount.calledWith(req.app).should.be.true();
done();
} catch (error) {
done(error);
}
});
});
it('does not mounts the active theme if it is already mounted', function (done) {
fakeActiveTheme.mounted = true;
executeMiddleware(middleware, req, res, function next(err) {
try {
should.not.exist(err);
fakeActiveTheme.mount.called.should.be.false();
done();
} catch (error) {
done(error);
}
});
});
it('throws error if theme is missing', function (done) {
activeTheme.get.restore();
sandbox.stub(activeTheme, 'get')
.returns(undefined);
executeMiddleware(middleware, req, res, function next(err) {
try {
// Did throw an error
should.exist(err);
err.message.should.eql('The currently active theme "bacon-sensation" is missing.');
activeTheme.get.called.should.be.true();
fakeActiveTheme.mount.called.should.be.false();
done();
} catch (error) {
done(error);
}
});
});
it('Sets res.locals.secure to the value of req.secure', function (done) {
req.secure = Math.random() < 0.5;
executeMiddleware(middleware, req, res, function next(err) {
try {
should.not.exist(err);
should.equal(res.locals.secure, req.secure);
done();
} catch (error) {
done(error);
}
});
});
describe('updateTemplateOptions', function () {
it('is called with correct data', function (done) {
const themeDataExpectedProps = ['posts_per_page', 'image_sizes'];
executeMiddleware(middleware, req, res, function next(err) {
try {
should.not.exist(err);
hbs.updateTemplateOptions.calledOnce.should.be.true();
const templateOptions = hbs.updateTemplateOptions.firstCall.args[0];
const data = templateOptions.data;
data.should.be.an.Object().with.properties('site', 'labs', 'config');
// Check Theme Config
data.config.should.be.an.Object()
.with.properties(themeDataExpectedProps)
.and.size(themeDataExpectedProps.length);
// posts per page should be set according to the stub
data.config.posts_per_page.should.eql(2);
// Check labs config
should.deepEqual(data.labs, fakeLabsData);
should.equal(data.site, fakeSiteData);
should.exist(data.site.signup_url);
data.site.signup_url.should.equal('#/portal');
done();
} catch (error) {
done(error);
}
});
});
it('switches @site.signup_url to RSS when signup is disabled', function (done) {
settingsCache.get
.withArgs('members_signup_access').returns('none');
executeMiddleware(middleware, req, res, function next(err) {
try {
const templateOptions = hbs.updateTemplateOptions.firstCall.args[0];
const data = templateOptions.data;
should.exist(data.site.signup_url);
data.site.signup_url.should.equal('https://feedly.com/i/subscription/feed/http%3A%2F%2F127.0.0.1%3A2369%2Frss%2F');
done();
} catch (error) {
done(error);
}
});
});
});
describe('Preview Mode', function () {
it('calls updateLocalTemplateOptions with correct data when one parameter is set', function (done) {
const previewString = 'c=%23000fff';
req.header = () => {
return previewString;
};
executeMiddleware(middleware, req, res, function next(err) {
try {
should.not.exist(err);
hbs.updateLocalTemplateOptions.calledOnce.should.be.true();
const templateOptions = hbs.updateLocalTemplateOptions.firstCall.args[1];
const data = templateOptions.data;
data.should.be.an.Object().with.properties('site');
data.site.should.be.an.Object().with.properties('accent_color', '_preview');
data.site._preview.should.eql(previewString);
data.site.accent_color.should.eql('#000fff');
done();
} catch (error) {
done(error);
}
});
});
it('calls updateLocalTemplateOptions with correct data when two parameters are set', function (done) {
const previewString = 'c=%23000fff&icon=%2Fcontent%2Fimages%2Fmyimg.png';
req.header = () => {
return previewString;
};
executeMiddleware(middleware, req, res, function next(err) {
try {
should.not.exist(err);
hbs.updateLocalTemplateOptions.calledOnce.should.be.true();
const templateOptions = hbs.updateLocalTemplateOptions.firstCall.args[1];
const data = templateOptions.data;
data.should.be.an.Object().with.properties('site');
data.site.should.be.an.Object().with.properties('accent_color', 'icon', '_preview');
data.site._preview.should.eql(previewString);
data.site.accent_color.should.eql('#000fff');
data.site.icon.should.eql('/content/images/myimg.png');
done();
} catch (error) {
done(error);
}
});
});
});
});