0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
ghost/core/server/services
Naz 85ee721157 Removed method complexity in settings API controller
refs https://github.com/TryGhost/Team/issues/694
refs https://linear.app/tryghost/issue/CORE-13

- The controller code is not meant to contain complex business logic.
Reduced complexity in the settings.read method
- Broke the usual "xxxService" naming pattern here in favor of "xxxBREADService" pattern that members package has been experimenting with recently (0469707f2e/packages/members-api/lib/services/member-bread.js (L25)). This naming choice was made because we already had a "SettingsService" and it would've become quite convoluted distinguishing the naming or doing renames for the sake of having a new temporary location for read/edit/add methods
- Also duplicated `hideValueIfSecret` method code with an intention to move it fully into the BREAD service once the refactoring is completed
2021-09-21 23:05:57 +12:00
..
adapter-manager
auth Lazily instantiated express-session middleware 2021-07-14 17:19:53 +01:00
bulk-email Fixed segmented email content being sent to all members 2021-09-10 11:36:42 +01:00
email-analytics Swapped to American English spellings 2021-08-09 13:35:01 +04:00
integrations Removed method complexity in integrations API controller 2021-09-16 14:23:48 +03:00
invitations
invites
jobs
mail Fixed linting issue 2021-09-17 16:51:52 +01:00
mega 🐛 Fixed Outlook incorrect text styling and ' appearing in email content (#13313) 2021-09-17 08:39:29 +01:00
members Passed MemberAnalyticEvent to @tryghost/members-api 2021-09-21 11:42:05 +02:00
notifications
permissions
posts Removed i18t dependency from post scheduling service 2021-09-04 07:49:11 +12:00
public-config Added a feature flag to the oauth login feature 2021-07-20 23:16:49 +02:00
route-settings
settings Removed method complexity in settings API controller 2021-09-21 23:05:57 +12:00
themes Removed i18t dependency from installer module 2021-09-03 20:33:28 +04:00
webhooks Removed method complexity in webhooks API controller 2021-09-17 10:11:23 +03:00
limits.js Fixed error when hostLimits are undefined 2021-07-23 20:46:52 +04:00
oembed.js Blocked 0.* IP addresses when making oembed requests 2021-09-14 11:35:14 +01:00
slack.js Added comments to all usages of lib/common/events 2021-07-07 16:02:44 +01:00
users.js
xmlrpc.js Added comments to all usages of lib/common/events 2021-07-07 16:02:44 +01:00