0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
ghost/core/test/unit/middleware
Hannah Wolfe e4a1797085 Remove should-sinon dependency
no issue

- removes should-sinon dependency from package.json
- rewrites all usages of should-sinon to use normal should assertions

Unfortunately, should-sinon has very minimal documentation  and therefore it is hard to discern what is considered a correctly-written assertion:
- in some cases, refactoring to use should-sinon causes false positives
- in other cases, assertions that work written in the normal way fail when written using should-sinon (e.g. getters, combos with rewire)
The additional overhead created by these issues outweigh any benefit from the easier-to-read assertions
2016-03-14 16:52:22 +00:00
..
auth-strategies_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
authentication_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
cache-control_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
check-ssl_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
decide-is-admin_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
oauth_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
private-blogging_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
redirect-to-setup_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
serve-shared-file_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
spam-prevention_spec.js Remove should-sinon dependency 2016-03-14 16:52:22 +00:00
static-theme_spec.js Merge pull request #6517 from halfdan/fix-6516 2016-02-18 08:37:32 +00:00
theme-handler_spec.js Removed uneeded jshint comments in order to cleanup the tests 2016-02-17 12:52:43 +00:00
uncapitalise_spec.js Remove should-sinon dependency 2016-03-14 16:52:22 +00:00