mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-03 23:00:14 -05:00
no issue - serving of our public asset images was broken - we were reading the binary file in as a string so we could do url transforms, this meant data was lost/corrupted and browsers could not display the served data - we were using the wrong mime-type for pngs which meant browsers were triggering downloads rather than displaying images (at least when accessed directly) - updates uses of `servePublicFile` to have the correct png mimetype - adjusts `servePublicFile` to treat any mime type starting with `image` as a binary file, passing the file directly through express using `res.sendFile` and skipping the in-memory content caching which is mostly only useful for text files with URL transforms |
||
---|---|---|
.. | ||
api | ||
image | ||
validation | ||
admin-redirects.js | ||
brute.js | ||
cache-control.js | ||
custom-redirects.js | ||
emit-events.js | ||
error-handler.js | ||
ghost-locals.js | ||
index.js | ||
labs.js | ||
log-request.js | ||
maintenance.js | ||
pretty-urls.js | ||
request-id.js | ||
serve-favicon.js | ||
serve-public-file.js | ||
static-theme.js | ||
uncapitalise.js | ||
update-user-last-seen.js | ||
upload.js | ||
url-redirects.js |