0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
ghost/core/server
Hannah Wolfe 7f29bbff8a Removed unused add/edit methods from integrations
refs 17feb14e4a

- The original commit adding this intended to add transactions, following the pattern of always forcing a transaction when we use bookshelf-relations
- (We use bookshelf-relations here because integrations have api-keys and webhooks associated wtih them and we upsert as one)
- These add and edit methods were inadvertently added to the wrong argument object/section of bookshelf (really fucking easily done, one day we will fix bookshelf so its easier to work with)
- Bottom line: these methods have never been called
- I tried moving them to the right section, but this created test failures throughout our acceptance tests:
   - Error: Transaction query already complete, run with DEBUG=knex:tx for more info
- This is likely because we need to account for integrations being used as part of the auth step in the before part of tests
- In terms of yak-shaving, fixing these tests is one step too far right now. I think not having this code here at all is a better state than having it look like it works when it doesn't
2021-02-25 10:48:05 +00:00
..
adapters Improved JSDoc in default scheduler 2020-12-16 17:25:05 +13:00
api Removed hardcoded currency symbols (#12700) 2021-02-25 09:49:07 +00:00
data Fixed typos connnection -> connection 2021-02-24 12:04:53 +13:00
lib Added mobiledoc.ghostVersion to blank mobiledoc document 2021-02-15 18:10:56 +00:00
models Removed unused add/edit methods from integrations 2021-02-25 10:48:05 +00:00
public Enabled Portal (#12317) 2020-11-03 14:36:21 +05:30
services Removed hardcoded currency symbols (#12700) 2021-02-25 09:49:07 +00:00
translations Added ability to install themes directly from GitHub (#12635) 2021-02-12 09:19:17 +00:00
views Added new, simpler, linear boot process 2021-02-08 11:56:44 +00:00
web Added new browse email endpoint 2021-02-22 13:55:20 +05:30
analytics-events.js Wrapped analytics tracker in try-catch 2021-02-24 15:57:38 +00:00
ghost-server.js Cleaned up use of express in ghost-server 2021-02-23 12:33:00 +00:00
notify.js Refactored notify to send started + ready 2021-02-19 20:42:10 +00:00
overrides.js Moved sqlite3 override rules to db connection lib 2021-02-05 11:51:56 +00:00
update-check.js