mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-24 23:48:13 -05:00
- 🛠 add bunyan and prettyjson, remove morgan - ✨ add logging module - GhostLogger class that handles setup of bunyan - PrettyStream for stdout - ✨ config for logging - @TODO: testing level fatal? - ✨ log each request via GhostLogger (express middleware) - @TODO: add errors to output - 🔥 remove errors.updateActiveTheme - we can read the value from config - 🔥 remove 15 helper functions in core/server/errors/index.js - all these functions get replaced by modules: 1. logging 2. error middleware handling for html/json 3. error creation (which will be part of PR #7477) - ✨ add express error handler for html/json - one true error handler for express responses - contains still some TODO's, but they are not high priority for first implementation/integration - this middleware only takes responsibility of either rendering html responses or return json error responses - 🎨 use new express error handler in middleware/index - 404 and 500 handling - 🎨 return error instead of error message in permissions/index.js - the rule for error handling should be: if you call a unit, this unit should return a custom Ghost error - 🎨 wrap serve static module - rule: if you call a module/unit, you should always wrap this error - it's always the same rule - so the caller never has to worry about what comes back - it's always a clear error instance - in this case: we return our notfounderror if serve static does not find the resource - this avoid having checks everywhere - 🎨 replace usages of errors/index.js functions and adapt tests - use logging.error, logging.warn - make tests green - remove some usages of logging and throwing api errors -> because when a request is involved, logging happens automatically - 🐛 return errorDetails to Ghost-Admin - errorDetails is used for Theme error handling - 🎨 use 500er error for theme is missing error in theme-handler - 🎨 extend file rotation to 1w
192 lines
6.4 KiB
JavaScript
192 lines
6.4 KiB
JavaScript
var Settings,
|
|
ghostBookshelf = require('./base'),
|
|
uuid = require('node-uuid'),
|
|
_ = require('lodash'),
|
|
errors = require('../errors'),
|
|
Promise = require('bluebird'),
|
|
validation = require('../data/validation'),
|
|
events = require('../events'),
|
|
internalContext = {context: {internal: true}},
|
|
i18n = require('../i18n'),
|
|
|
|
defaultSettings;
|
|
|
|
// For neatness, the defaults file is split into categories.
|
|
// It's much easier for us to work with it as a single level
|
|
// instead of iterating those categories every time
|
|
function parseDefaultSettings() {
|
|
var defaultSettingsInCategories = require('../data/schema/').defaultSettings,
|
|
defaultSettingsFlattened = {};
|
|
|
|
_.each(defaultSettingsInCategories, function each(settings, categoryName) {
|
|
_.each(settings, function each(setting, settingName) {
|
|
setting.type = categoryName;
|
|
setting.key = settingName;
|
|
|
|
defaultSettingsFlattened[settingName] = setting;
|
|
});
|
|
});
|
|
|
|
return defaultSettingsFlattened;
|
|
}
|
|
|
|
function getDefaultSettings() {
|
|
if (!defaultSettings) {
|
|
defaultSettings = parseDefaultSettings();
|
|
}
|
|
|
|
return defaultSettings;
|
|
}
|
|
|
|
// Each setting is saved as a separate row in the database,
|
|
// but the overlying API treats them as a single key:value mapping
|
|
Settings = ghostBookshelf.Model.extend({
|
|
|
|
tableName: 'settings',
|
|
|
|
defaults: function defaults() {
|
|
return {
|
|
uuid: uuid.v4(),
|
|
type: 'core'
|
|
};
|
|
},
|
|
|
|
emitChange: function emitChange(event) {
|
|
events.emit('settings' + '.' + event, this);
|
|
},
|
|
|
|
initialize: function initialize() {
|
|
ghostBookshelf.Model.prototype.initialize.apply(this, arguments);
|
|
|
|
this.on('created', function (model) {
|
|
model.emitChange('added');
|
|
model.emitChange(model.attributes.key + '.' + 'added');
|
|
});
|
|
this.on('updated', function (model) {
|
|
model.emitChange('edited');
|
|
model.emitChange(model.attributes.key + '.' + 'edited');
|
|
});
|
|
this.on('destroyed', function (model) {
|
|
model.emitChange('deleted');
|
|
model.emitChange(model.attributes.key + '.' + 'deleted');
|
|
});
|
|
},
|
|
|
|
validate: function validate() {
|
|
var self = this,
|
|
setting = this.toJSON();
|
|
|
|
return validation.validateSchema(self.tableName, setting).then(function then() {
|
|
return validation.validateSettings(getDefaultSettings(), self);
|
|
}).then(function () {
|
|
var themeName = setting.value || '';
|
|
|
|
if (setting.key !== 'activeTheme') {
|
|
return;
|
|
}
|
|
|
|
return validation.validateActiveTheme(themeName);
|
|
});
|
|
}
|
|
}, {
|
|
findOne: function (data, options) {
|
|
if (_.isEmpty(data)) {
|
|
options = data;
|
|
}
|
|
|
|
// Allow for just passing the key instead of attributes
|
|
if (!_.isObject(data)) {
|
|
data = {key: data};
|
|
}
|
|
|
|
return Promise.resolve(ghostBookshelf.Model.findOne.call(this, data, options));
|
|
},
|
|
|
|
edit: function (data, options) {
|
|
var self = this;
|
|
options = this.filterOptions(options, 'edit');
|
|
|
|
if (!Array.isArray(data)) {
|
|
data = [data];
|
|
}
|
|
|
|
return Promise.map(data, function (item) {
|
|
// Accept an array of models as input
|
|
if (item.toJSON) { item = item.toJSON(); }
|
|
if (!(_.isString(item.key) && item.key.length > 0)) {
|
|
return Promise.reject(new errors.ValidationError(i18n.t('errors.models.settings.valueCannotBeBlank')));
|
|
}
|
|
|
|
item = self.filterData(item);
|
|
|
|
return Settings.forge({key: item.key}).fetch(options).then(function then(setting) {
|
|
var saveData = {};
|
|
|
|
if (setting) {
|
|
if (item.hasOwnProperty('value')) {
|
|
saveData.value = item.value;
|
|
}
|
|
// Internal context can overwrite type (for fixture migrations)
|
|
if (options.context && options.context.internal && item.hasOwnProperty('type')) {
|
|
saveData.type = item.type;
|
|
}
|
|
// it's allowed to edit all attributes in case of importing/migrating
|
|
if (options.importing) {
|
|
saveData = item;
|
|
}
|
|
|
|
return setting.save(saveData, options);
|
|
}
|
|
|
|
return Promise.reject(new errors.NotFoundError(i18n.t('errors.models.settings.unableToFindSetting', {key: item.key})));
|
|
});
|
|
});
|
|
},
|
|
|
|
populateDefault: function (key) {
|
|
if (!getDefaultSettings()[key]) {
|
|
return Promise.reject(new errors.NotFoundError(i18n.t('errors.models.settings.unableToFindDefaultSetting', {key: key})));
|
|
}
|
|
|
|
return this.findOne({key: key}).then(function then(foundSetting) {
|
|
if (foundSetting) {
|
|
return foundSetting;
|
|
}
|
|
|
|
var defaultSetting = _.clone(getDefaultSettings()[key]);
|
|
defaultSetting.value = defaultSetting.defaultValue;
|
|
|
|
return Settings.forge(defaultSetting).save(null, internalContext);
|
|
});
|
|
},
|
|
|
|
populateDefaults: function populateDefaults(options) {
|
|
options = options || {};
|
|
|
|
options = _.merge({}, options, internalContext);
|
|
|
|
return this.findAll(options).then(function then(allSettings) {
|
|
var usedKeys = allSettings.models.map(function mapper(setting) { return setting.get('key'); }),
|
|
insertOperations = [];
|
|
|
|
_.each(getDefaultSettings(), function each(defaultSetting, defaultSettingKey) {
|
|
var isMissingFromDB = usedKeys.indexOf(defaultSettingKey) === -1;
|
|
// Temporary code to deal with old databases with currentVersion settings
|
|
if (defaultSettingKey === 'databaseVersion' && usedKeys.indexOf('currentVersion') !== -1) {
|
|
isMissingFromDB = false;
|
|
}
|
|
if (isMissingFromDB) {
|
|
defaultSetting.value = defaultSetting.defaultValue;
|
|
insertOperations.push(Settings.forge(defaultSetting).save(null, options));
|
|
}
|
|
});
|
|
|
|
return Promise.all(insertOperations);
|
|
});
|
|
}
|
|
|
|
});
|
|
|
|
module.exports = {
|
|
Settings: ghostBookshelf.model('Settings', Settings)
|
|
};
|