mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-17 23:44:39 -05:00
Initial Subscribers screen
- set up mocked api endpoints
- basic subscribers screen with data loading, infinite scroll
"Add Subscriber" screen
- uses modal to display a new subscriber form
- validates subscriber e-mail address
- moves pagination from route into controller to use filtered/sorted CPs on top of a live-query so that new subscribers are added to the list and the total can be properly managed
TODO:
- there is currently a pretty serious performance issue where the whole table is re-rendered when the live-query is updated. `ember-light-table` doesn't allow for live-binding and has no options to easily manipulate it's rows using an external interface - it's possible to move the page loading into the component so we only render new rows but that leaves it difficult to react to new subscribers being added through the UI. I believe the number of components used within the table is also adding to the performance problems.
- most likely solution is to drop `ember-light-table` in favour of rendering the table directly - glimmer should do a good job of fast updates even though the underlying array will be completely swapped out
"Import subscribers" screen
- uses modal to display an import subscribers CSV file upload form
- displays upload progress
- displays import stats and reloads subscribers table once import has completed
- adds `gh-file-uploader` component (NB. pared down copy of `gh-image-uploader`, ripe for some refactoring)
- fixes subscribers acceptance test failing because fixtures did not have the labs flag enabled
Unfortunately this doesn't have 100% test coverage as we're limited in how we can simulate file uploads 😞
Fix performance issues with subscribers table
- moves the table definition from the component up to the controller
- switches back to manually manipulating table rows instead of using a live-query
This is a quick-fix in that it allows us to continue using the `ember-light-table` component but it does mean that we lose some flexibility that the live-query gave us. For now it's not much of an issue and it allows us to defer deeper performance/flexibility work until we have a concrete need and requirements.
Hook up Export CSV button
- use a hidden iFrame to trigger the browser to hit the CSV export endpoint and download the file
Re-order subscribers table by clicking column headers
- displays currently sorted column and sort direction
- clicking a column header re-fetches the data from the server with the appropriate query params
Fix scroll triggers for infinite pagination + icon change
- adds a debounce as well as the throttle so that we always get a final scroll trigger once scrolling has stopped
- changes the subscribers icon from the temporary team icon to the mail icon
162 lines
5.8 KiB
JavaScript
162 lines
5.8 KiB
JavaScript
import Ember from 'ember';
|
|
import DS from 'ember-data';
|
|
import Model from 'ember-data/model';
|
|
import getRequestErrorMessage from 'ghost/utils/ajax';
|
|
|
|
import InviteUserValidator from 'ghost/validators/invite-user';
|
|
import NavItemValidator from 'ghost/validators/nav-item';
|
|
import PostValidator from 'ghost/validators/post';
|
|
import ResetValidator from 'ghost/validators/reset';
|
|
import SettingValidator from 'ghost/validators/setting';
|
|
import SetupValidator from 'ghost/validators/setup';
|
|
import SigninValidator from 'ghost/validators/signin';
|
|
import SignupValidator from 'ghost/validators/signup';
|
|
import SlackIntegrationValidator from 'ghost/validators/slack-integration';
|
|
import SubscriberValidator from 'ghost/validators/subscriber';
|
|
import TagSettingsValidator from 'ghost/validators/tag-settings';
|
|
import UserValidator from 'ghost/validators/user';
|
|
|
|
import ValidatorExtensions from 'ghost/utils/validator-extensions';
|
|
|
|
const {Mixin, RSVP, isArray} = Ember;
|
|
const {Errors} = DS;
|
|
const emberA = Ember.A;
|
|
|
|
// our extensions to the validator library
|
|
ValidatorExtensions.init();
|
|
|
|
/**
|
|
* The class that gets this mixin will receive these properties and functions.
|
|
* It will be able to validate any properties on itself (or the model it passes to validate())
|
|
* with the use of a declared validator.
|
|
*/
|
|
export default Mixin.create({
|
|
// these validators can be passed a model to validate when the class that
|
|
// mixes in the ValidationEngine declares a validationType equal to a key on this object.
|
|
// the model is either passed in via `this.validate({ model: object })`
|
|
// or by calling `this.validate()` without the model property.
|
|
// in that case the model will be the class that the ValidationEngine
|
|
// was mixed into, i.e. the controller or Ember Data model.
|
|
validators: {
|
|
inviteUser: InviteUserValidator,
|
|
navItem: NavItemValidator,
|
|
post: PostValidator,
|
|
reset: ResetValidator,
|
|
setting: SettingValidator,
|
|
setup: SetupValidator,
|
|
signin: SigninValidator,
|
|
signup: SignupValidator,
|
|
slackIntegration: SlackIntegrationValidator,
|
|
subscriber: SubscriberValidator,
|
|
tag: TagSettingsValidator,
|
|
user: UserValidator
|
|
},
|
|
|
|
// This adds the Errors object to the validation engine, and shouldn't affect
|
|
// ember-data models because they essentially use the same thing
|
|
errors: null,
|
|
|
|
// Store whether a property has been validated yet, so that we know whether or not
|
|
// to show error / success validation for a field
|
|
hasValidated: null,
|
|
|
|
init() {
|
|
this._super(...arguments);
|
|
this.set('errors', Errors.create());
|
|
this.set('hasValidated', emberA());
|
|
},
|
|
|
|
/**
|
|
* Passes the model to the validator specified by validationType.
|
|
* Returns a promise that will resolve if validation succeeds, and reject if not.
|
|
* Some options can be specified:
|
|
*
|
|
* `model: Object` - you can specify the model to be validated, rather than pass the default value of `this`,
|
|
* the class that mixes in this mixin.
|
|
*
|
|
* `property: String` - you can specify a specific property to validate. If
|
|
* no property is specified, the entire model will be
|
|
* validated
|
|
*/
|
|
validate(opts) {
|
|
let model = this;
|
|
let hasValidated,
|
|
type,
|
|
validator;
|
|
|
|
opts = opts || {};
|
|
|
|
if (opts.model) {
|
|
model = opts.model;
|
|
} else if (this instanceof Model) {
|
|
model = this;
|
|
} else if (this.get('model')) {
|
|
model = this.get('model');
|
|
}
|
|
|
|
type = this.get('validationType') || model.get('validationType');
|
|
validator = this.get(`validators.${type}`) || model.get(`validators.${type}`);
|
|
hasValidated = this.get('hasValidated');
|
|
|
|
opts.validationType = type;
|
|
|
|
return new RSVP.Promise((resolve, reject) => {
|
|
let passed;
|
|
|
|
if (!type || !validator) {
|
|
return reject([`The validator specified, "${type}", did not exist!`]);
|
|
}
|
|
|
|
if (opts.property) {
|
|
// If property isn't in `hasValidated`, add it to mark that this field can show a validation result
|
|
hasValidated.addObject(opts.property);
|
|
model.get('errors').remove(opts.property);
|
|
} else {
|
|
model.get('errors').clear();
|
|
}
|
|
|
|
passed = validator.check(model, opts.property);
|
|
|
|
return (passed) ? resolve() : reject();
|
|
});
|
|
},
|
|
|
|
/**
|
|
* The primary goal of this method is to override the `save` method on Ember Data models.
|
|
* This allows us to run validation before actually trying to save the model to the server.
|
|
* You can supply options to be passed into the `validate` method, since the ED `save` method takes no options.
|
|
*/
|
|
save(options) {
|
|
let {_super} = this;
|
|
|
|
options = options || {};
|
|
options.wasSave = true;
|
|
|
|
// model.destroyRecord() calls model.save() behind the scenes.
|
|
// in that case, we don't need validation checks or error propagation,
|
|
// because the model itself is being destroyed.
|
|
if (this.get('isDeleted')) {
|
|
return this._super(...arguments);
|
|
}
|
|
|
|
// If validation fails, reject with validation errors.
|
|
// If save to the server fails, reject with server response.
|
|
return this.validate(options).then(() => {
|
|
return _super.call(this, options);
|
|
}).catch((result) => {
|
|
// server save failed or validator type doesn't exist
|
|
if (result && !isArray(result)) {
|
|
// return the array of errors from the server
|
|
result = getRequestErrorMessage(result);
|
|
}
|
|
|
|
return RSVP.reject(result);
|
|
});
|
|
},
|
|
|
|
actions: {
|
|
validate(property) {
|
|
this.validate({property});
|
|
}
|
|
}
|
|
});
|