0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
ghost/core/server/services
Kevin Ansfield a485509a2f
🐛 Fixed GA labs flags not appearing enabled in settings API (#13681)
no issue

The way GA flags were introduced means that they stop existing in the `'labs'` setting in the db and are instead forced to always return `true` when checking the flag in the labs service. However, Admin which uses the flags fetches them via the `/settings/` API endpoint which was only returning the raw labs setting db value meaning GA flags appeared to be disabled unless the flag had previously been enabled and no settings save had occured.

- updated the settings bread service to replace the labs setting value with the JSON stringified output of `labs.getAll()` which is the ultimate source-of-truth for a feature being enabled/disabled
  - extracted `browse()` behaviour to an internal `_formatBrowse()` method so we can apply the same filtering/modification for output of `browse()` and `edit()`

Co-authored-by: Fabien O'Carroll <fabien@allou.is>
2021-10-22 19:59:13 +01:00
..
adapter-manager Added multiple adapters capability to adapter manager 2021-10-21 20:22:45 +13:00
auth Replaced i18n.t w/ tpl helper in core/server/services/auth (#13458) 2021-10-06 09:42:44 +01:00
bulk-email Inlined package requires to save boot time and memory 2021-10-22 09:57:59 +02:00
email-analytics Swapped to American English spellings 2021-08-09 13:35:01 +04:00
integrations Removed method complexity in integrations API controller 2021-09-16 14:23:48 +03:00
invitations Replaced i18n with tpl in accept.js (#13471) 2021-10-08 15:21:22 +01:00
invites Refactored tpl to never be used in DI 2021-10-11 15:19:54 +01:00
jobs Change to use @tryghost/logging 2021-06-15 15:59:11 +01:00
mail Replaced i18n with tpl in GhostMailer.js (#13555) 2021-10-12 09:10:50 +01:00
mega Fixed missing space between authors in emails 2021-10-22 14:41:15 +01:00
members Fixed verification threshold when set to 0 2021-10-22 15:33:59 +02:00
notifications Simplified Notification's service constructor 2021-10-11 16:04:48 +02:00
offers Fixed error when enabling Offers via labs 2021-10-21 20:05:42 +02:00
permissions Replaced i18n.t with tpl in core/server/services/bulk-email and core/server/services/permissions (#13562) 2021-10-12 14:46:35 +01:00
posts 🐛 Fixed immediately sent email when scheduling email-only post 2021-10-05 16:42:29 +02:00
public-config Added a feature flag to the oauth login feature 2021-07-20 23:16:49 +02:00
redirects Added validation to redirects config 2021-10-04 18:32:40 +02:00
route-settings Moved URL service to backend 2021-10-19 07:29:09 +13:00
settings 🐛 Fixed GA labs flags not appearing enabled in settings API (#13681) 2021-10-22 19:59:13 +01:00
stripe Moved StripeAPIService to its own service 2021-10-04 19:28:19 +02:00
themes Fixed custom theme settings not being available when expected 2021-10-21 15:02:52 +01:00
url Moved URL service to backend 2021-10-19 07:29:09 +13:00
webhooks Removed method complexity in webhooks API controller 2021-09-17 10:11:23 +03:00
custom-theme-settings.js Added API tests for custom theme settings (#13519) 2021-10-08 16:18:49 +01:00
limits.js Fixed error when hostLimits are undefined 2021-07-23 20:46:52 +04:00
oembed.js Refactored tpl to never be used in DI 2021-10-11 15:19:54 +01:00
slack.js Moved URL service to backend 2021-10-19 07:29:09 +13:00
users.js 🔒 Added a "reset all passwords" feature (#13005) 2021-06-23 14:54:28 +02:00
xmlrpc.js Moved URL service to backend 2021-10-19 07:29:09 +13:00