0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
ghost/ghost
Chris Raible 64c9e66b56
🐛 Fixed broken link tracking in newsletters (#16473)
refs https://github.com/TryGhost/Team/issues/2805

When we render mobiledoc to HTML, it automatically escapes HTML entities in the process, so a button or directly pasted link with href="https://example.com?code=test" will be rendered as href="https://example.com?code&#x3Dtest" as the url is encoded in the rendered HTML. Our link tracking was using the encoded URL as the redirect URL in newsletters, causing certain links to break.

This change updates the link tracking to decode the URL with `entities.decode(url)` so we store the correct redirect URL in our DB and ensure link tracking redirects to the correct url from newsletters.

---------

Co-authored-by: Rishabh <zrishabhgarg@gmail.com>
2023-03-24 18:44:55 +05:30
..
adapter-cache-memory-ttl Update dependency @isaacs/ttlcache to v1.2.2 2023-03-23 20:20:25 +00:00
adapter-cache-redis
adapter-manager
admin Copied over preview labs change 2023-03-24 11:00:52 +01:00
api-framework
api-version-compatibility-service
audience-feedback
bootstrap-socket
constants
core Added Toggle Card (first version) 2023-03-24 12:42:58 +01:00
custom-theme-settings-service
data-generator Fixed the reply-to address for newsletters in data generator 2023-03-22 14:56:51 +00:00
domain-events
dynamic-routing-events
email-analytics-provider-mailgun
email-analytics-service
email-content-generator Update dependency fs-extra to v11.1.1 2023-03-21 07:35:30 +01:00
email-events
email-service 🐛 Fixed broken link tracking in newsletters (#16473) 2023-03-24 18:44:55 +05:30
email-suppression-list
event-aware-cache-wrapper
express-dynamic-redirects
external-media-inliner
extract-api-key
html-to-plaintext
i18n Add i18n context 2023-03-23 12:07:12 -04:00
importer-handler-content-files Fixed root zip media/files copying during import 2023-03-16 22:48:57 +01:00
importer-revue Fixed random unit test failure for revue importer 2023-03-21 10:46:13 +01:00
job-manager
link-redirects
link-replacer
link-tracking
magic-link
mailgun-client
member-attribution Fixed incorrect newsletter ref for internal links 2023-03-17 20:55:52 +05:30
member-events Removed circular dependency definition 2023-03-23 08:58:59 +01:00
members-api Disabled got retries in testing environment 2023-03-24 11:55:57 +01:00
members-csv Update dependency fs-extra to v11.1.1 2023-03-21 07:35:30 +01:00
members-events-service
members-importer Update dependency fs-extra to v11.1.1 2023-03-21 07:35:30 +01:00
members-ssr
mentions-email-report
milestones
minifier
mw-api-version-mismatch
mw-cache-control
mw-error-handler
mw-session-from-token
mw-update-user-last-seen
mw-version-match
mw-vhost
oembed-service Disabled got retries in testing environment 2023-03-24 11:55:57 +01:00
offers
package-json Update dependency fs-extra to v11.1.1 2023-03-21 07:35:30 +01:00
payments
portal Update sentry-javascript monorepo to v7.44.2 2023-03-21 15:10:15 +01:00
posts-service Added posts exporter implementation (#16467) 2023-03-22 09:08:35 +01:00
referrers
security
session-service
settings-path-manager
slack-notifications Disabled got retries in testing environment 2023-03-24 11:55:57 +01:00
sodo-search Update dependency @testing-library/react to v12.1.5 2023-03-17 23:38:13 +00:00
staff-service Moved Milestone emails to GA 2023-03-23 17:35:23 +00:00
stats-service
stripe
tiers
update-check-service
verification-trigger Prevent errors during the verification trigger tests 2023-03-24 12:32:28 +00:00
version-notifications-data-service
webmentions Updated fallback for storing source site title 2023-03-21 16:09:21 +05:30