mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-03 23:00:14 -05:00
623c65c509
fixes #10990 - Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file - Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template - The new error reads 'Missing template [filename].hbs for route "[route]".' Assume you have a route.yaml file something like: ``` routes: /: home ``` - In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available - Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself - In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded - This is due to this issue: https://github.com/barc/express-hbs/issues/161 - In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback - In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".' |
||
|---|---|---|
| .. | ||
| api | ||
| apps/subscribers | ||
| exporter | ||
| importer | ||
| migrations | ||
| models | ||
| site | ||
| update-check | ||
| README.md | ||
Regression Tests
This folder should contain packages which we test in a cron job once per day. These tests should ensure that we don't break Ghost.
The goal is that most of these packages use Ghost's API's to test behaviours, otherwise transform the tests into unit tests.