0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
ghost/apps
Peter Zimon 620b42f275
Fixed Select component catching all ESC keypresses (#21977)
closes
https://linear.app/ghost/issue/DES-1075/regression-esc-doesnt-close-admin-settings

- Hitting ESC in Admin/Settings while nothing is in focus should close
Settings and navigate back to the Dashboard — instead, right now nothing
happens when `ESC` is hit. The problem was that the `Select` component
in the current Design System caught `ESC` keystrokes and stopped
propagating them even if they were not in focus. This issue wasn't
apparent so far because no `Select` components were rendered directly on
the Settings page. However, in a [recent
change](ab2c7f18e2)
we moved out some select components from Access settings to the main
Settings view, which immediately stopped propagating `ESC` keystrokes to
the main component. This fix adds a check if the `Select` (or any other)
component is in focus and stops propagation only if that's true.
2025-01-08 15:13:00 +01:00
..
admin-x-activitypub Reduce number of notifications retrieved in admin-x-activtypub (#21928) 2024-12-19 15:28:15 +00:00
admin-x-demo
admin-x-design-system Fixed Select component catching all ESC keypresses (#21977) 2025-01-08 15:13:00 +01:00
admin-x-framework Added option to disable free signups (#21862) 2024-12-20 02:43:48 +08:00
admin-x-settings Disable "Create" button after first click in "Create newsletter" modal 2025-01-07 16:56:13 +00:00
announcement-bar 2025 2025-01-06 11:40:59 +00:00
comments-ui 2025 2025-01-06 11:40:59 +00:00
portal Released Portal v2.47.1 (#21967) 2025-01-07 09:06:41 +00:00
posts Adding Posts analytics React app (#21878) 2024-12-19 12:01:08 +01:00
shade Pin dependencies 2025-01-07 12:11:37 +01:00
signup-form Bumped signup form package (#21631) 2024-11-15 19:11:29 +00:00
sodo-search 2025 2025-01-06 11:40:59 +00:00