0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
ghost/core/server/middleware
Aileen Nowak 5c94151e14 Blog icon validations (#7893)
refs #7688

Adds an `uploads/icon/` endpoint to the api route to get a seperate entry point for blog icon validations. The blog icon validation will specifically check for images which have icon extensions (`.ico` & `.png`) and throw errors if:

- the icon file size is too big (>100kb)
- the icon is not a squaer
- the icon size is smaller than 32px
- the icon size is larger than 1000px
- the icon is not `.ico` or `.png` extension

TODOs for this PR:
- [X] get image dimensions
- [X] validate for image
	- [X] size
	- [X] form (must be square)
	- [X] type
	- [X] dimenstion (min 32px and max 1,000px)
- [X] return appropriate error messages
- [X] write tests

--------------------

TODOs for #7688:
- [X] Figure out, which favicon should be used (uploaded or default) -> #7713
- [ ] Serve and redirect the favicon for any browser requests, incl. redirects -> #7700 [WIP]
- [X] Upload favicon via `general/settings` and implement basic admin validations -> TryGhost/Ghost-Admin#397
- [X] Build server side validations -> this PR
2017-01-26 10:01:52 +01:00
..
api 🎨 optimisations for brute (#7867) 2017-01-23 22:44:39 +01:00
validation Blog icon validations (#7893) 2017-01-26 10:01:52 +01:00
brute.js 🎨 optimisations for brute (#7867) 2017-01-23 22:44:39 +01:00
cache-control.js
check-ssl.js More consistant usage of urlFor('home') (#7689) 2017-01-23 09:22:37 +01:00
error-handler.js 🎨 error improvements (#7600) 2016-10-21 13:10:17 +01:00
ghost-locals.js Misc Middleware cleanup (#7526) 2016-10-10 21:14:32 +02:00
labs.js 🎨 configurable logging with bunyan (#7431) 2016-10-04 16:33:43 +01:00
log-request.js chore(package): update uuid to version 3.0.0 (#7742) 2017-01-04 17:10:29 +01:00
maintenance.js Error creation (#7477) 2016-10-06 13:27:35 +01:00
pretty-urls.js Misc Middleware cleanup (#7526) 2016-10-10 21:14:32 +02:00
redirect-to-setup.js Ghost OAuth (#7451) 2016-09-30 12:45:59 +01:00
serve-shared-file.js More consistant usage of urlFor('home') (#7689) 2017-01-23 09:22:37 +01:00
static-theme.js Fixed caching of theme in development mode. (#7812) (#7857) 2017-01-25 15:10:46 +01:00
theme-handler.js Misc Middleware cleanup (#7526) 2016-10-10 21:14:32 +02:00
uncapitalise.js Misc Middleware cleanup (#7526) 2016-10-10 21:14:32 +02:00