0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Independent technology for modern publishing, memberships, subscriptions and newsletters.
Find a file
Steve Larson 59b304dfca
🐛 Fixed editor 'are you sure?' modal displaying when no user changes occurred (#20370)
ref https://linear.app/tryghost/issue/ENG-661
- added a dirty check to ignore the `direction` field from the lexical
object; this is set dynamically and shouldn't be serialized, see
facebook/lexical/issues/4998
- fixed a bug where the modal wouldn't display on leaving the editor if
the post had no revisions (e.g. import); this could result in content
being saved over published content with no user action
- added Sentry logging for the modal

We would sometimes see the "Are you sure?" modal pop up when opening a
post in the editor and attempting to navigate away immediately, without
any changes to the post. This appears to be an issue with the serialized
Lexical data, which would change after loading into the editor,
resulting in the scratch and model's lexical values to differ, making
Admin think the user changed the content.

Ideally we'll see a fix upstream (or fix it ourselves). We may need to
revisit this if we experience other such situations. It's awfully
difficult to be able to set a flag saying 'the editor is done loading',
so this seems to be the best path for the moment.

Testing is difficult because we don't actually load the new Lexical editor into e2e/acceptance tests. I've added a unit test that can at least simulate the editor state changing on editor load.
2024-06-13 11:07:56 -05:00
.github Update benchmark-action/github-action-benchmark action to v1.20.3 2024-05-20 10:39:02 +01:00
.vscode Added backend launch task 2024-01-17 17:52:36 +07:00
apps Published new version of Comments-UI (#20380) 2024-06-13 09:25:31 +07:00
ghost 🐛 Fixed editor 'are you sure?' modal displaying when no user changes occurred (#20370) 2024-06-13 11:07:56 -05:00
.editorconfig
.envrc Added initial setup for direnv 2024-02-27 21:49:56 +07:00
.gitattributes
.gitignore Added initial setup for direnv 2024-02-27 21:49:56 +07:00
.gitmodules Added Source as the new default theme 2023-10-03 14:02:08 +02:00
flake.lock Added initial setup for direnv 2024-02-27 21:49:56 +07:00
flake.nix Added initial setup for direnv 2024-02-27 21:49:56 +07:00
LICENSE
nx.json Added defaults to Nx build step 2023-12-13 11:54:31 +01:00
package.json Update dependency lint-staged to v15.2.7 2024-06-13 09:50:40 +02:00
PRIVACY.md Removed outdated line from PRIVACY.md (#18789) 2023-12-13 12:39:45 +01:00
README.md Removed job posting (#19765) 2024-04-16 13:25:16 +02:00
SECURITY.md
yarn.lock Update dependency lint-staged to v15.2.7 2024-06-13 09:50:40 +02:00

 

Ghost Ghost

 

Ghost.orgForumDocsContributingTwitter

Downloads Latest release Build status Contributors

 

Fiercely independent, professional publishing. Ghost is the most popular open source, headless Node.js CMS which already works with all the tools you know and love.

 

Ghost(Pro) Ghost(Pro)

The easiest way to get a production instance deployed is with our official Ghost(Pro) managed service. It takes about 2 minutes to launch a new site with worldwide CDN, backups, security and maintenance all done for you.

For most people this ends up being the best value option because of how much time it saves — and 100% of revenue goes to the Ghost Foundation; funding the maintenance and further development of the project itself. So youll be supporting open source software and getting a great service!

 

Quickstart install

If you want to run your own instance of Ghost, in most cases the best way is to use our CLI tool

npm install ghost-cli -g

 

Then, if installing locally add the local flag to get up and running in under a minute - Local install docs

ghost install local

 

or on a server run the full install, including automatic SSL setup using LetsEncrypt - Production install docs

ghost install

 

Check out our official documentation for more information about our recommended hosting stack & properly upgrading Ghost, plus everything you need to develop your own Ghost themes or work with our API.

Contributors & advanced developers

For anyone wishing to contribute to Ghost or to hack/customize core files we recommend following our full development setup guides: Contributor guideDeveloper setup

 

Ghost sponsors

We'd like to extend big thanks to our sponsors and partners who make Ghost possible. If you're interested in sponsoring Ghost and supporting the project, please check out our profile on GitHub sponsors ❤️

DigitalOceanFastly

 

Getting help

You can find answers to a huge variety of questions, along with a large community of helpful developers over on the Ghost forum - replies are generally very quick. Ghost(Pro) customers also have access to 24/7 email support.

To stay up to date with all the latest news and product updates, make sure you subscribe to our blog — or you can always follow us on Twitter, if you prefer your updates bite-sized and facetious. 🎷🐢

 

Copyright & license

Copyright (c) 2013-2023 Ghost Foundation - Released under the MIT license. Ghost and the Ghost Logo are trademarks of Ghost Foundation Ltd. Please see our trademark policy for info on acceptable usage.