0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
ghost/core/server
naz 51c9a50c4f
Added validation layer to members import endpoint (#12131)
no issue

- Additional validation is needed for imported data because in case of bulk insertions (through knex) we bypass model layer validation - this could lead to invalid data in the database, which would be hard to fix.
- Chose validation method we use for other endpoints - through JSON Schema. It proved to be very performant (200ms overhead for 50k records). When comparing it with iterative method (validating each record separately) this was adding about 17s of overhead.
- Refactored returned values from "sanitizeInput" method to encapsulate more logic so that the caller doesn't have to calculate amount of invalid records and deal with error types
- Whole sanitizeInput method could now be easily extracted into separate module (somewhere close to members importer)
- Bumped members-csv package. It is meant to handle empty string values - '' and null, which should allow validating member records more consistently!
2020-08-17 23:28:57 +12:00
..
adapters Replaced constants file with @tryghost/constants 2020-08-11 12:51:16 +01:00
api Added validation layer to members import endpoint (#12131) 2020-08-17 23:28:57 +12:00
data Extracted promise libs and history into @tryghost/promise 2020-08-11 18:44:21 +01:00
lib Extracted promise libs and history into @tryghost/promise 2020-08-11 18:44:21 +01:00
models Replaced all usage of member models with members-api (#12117) 2020-08-12 14:17:44 +01:00
public Renamed members ssr + api endpoints 2020-04-30 19:00:37 +01:00
services Fixed parameter naming for members importer 2020-08-13 21:08:34 +12:00
translations Added an additional log to notify shutdown start 2020-08-10 14:53:05 +01:00
views Updated head to only output custom favicons (#11949) 2020-06-30 15:07:08 +01:00
web Added job-manager & wired up shutdown and testmode 2020-08-11 21:31:34 +01:00
analytics-events.js Moved config from server to shared (#11850) 2020-05-27 18:47:53 +01:00
ghost-server.js Removed workaround for intermittent ghost-server logging 2020-08-13 18:45:51 +01:00
index.js Added job-manager & wired up shutdown and testmode 2020-08-11 21:31:34 +01:00
overrides.js
update-check.js Moved core/server/lib/common/logging to core/shared/logging (#11857) 2020-05-28 19:30:23 +01:00