0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
ghost/test/unit/lib/image/cached-image-size-from-url_spec.js
Kevin Ansfield 32dd4574af Fixed non-reverted rewire of imageSize.getImageSizeFromUrl in tests
no issue

- fixes unexpected behaviour in tests run after the `cached-image-size-from-url_spec.js` unit tests
2020-06-16 20:58:02 +01:00

99 lines
3.7 KiB
JavaScript

const should = require('should');
const sinon = require('sinon');
const Promise = require('bluebird');
const rewire = require('rewire');
// Stuff we are testing
const getCachedImageSizeFromUrl = rewire('../../../../core/server/lib/image/cached-image-size-from-url');
describe('lib/image: image size cache', function () {
let sizeOfStub;
let cachedImagedSize;
let revertGetCachedImageSizeFromUrl;
beforeEach(function () {
sizeOfStub = sinon.stub();
});
afterEach(function () {
sinon.restore();
getCachedImageSizeFromUrl.__set__('cache', {});
if (revertGetCachedImageSizeFromUrl) {
revertGetCachedImageSizeFromUrl();
}
});
it('should read from cache, if dimensions for image are fetched already', function (done) {
const url = 'http://mysite.com/content/image/mypostcoverimage.jpg';
let cachedImagedSizeResult;
let imageSizeSpy;
sizeOfStub.returns(new Promise.resolve({
width: 50,
height: 50,
type: 'jpg'
}));
revertGetCachedImageSizeFromUrl = getCachedImageSizeFromUrl.__set__('imageSize.getImageSizeFromUrl', sizeOfStub);
imageSizeSpy = getCachedImageSizeFromUrl.__get__('imageSize.getImageSizeFromUrl');
cachedImagedSizeResult = Promise.resolve(getCachedImageSizeFromUrl(url));
cachedImagedSizeResult.then(function () {
// first call to get result from `getImageSizeFromUrl`
cachedImagedSize = getCachedImageSizeFromUrl.__get__('cache');
should.exist(cachedImagedSize);
cachedImagedSize.should.have.property(url);
should.exist(cachedImagedSize[url].width);
cachedImagedSize[url].width.should.be.equal(50);
should.exist(cachedImagedSize[url].height);
cachedImagedSize[url].height.should.be.equal(50);
// second call to check if values get returned from cache
cachedImagedSizeResult = Promise.resolve(getCachedImageSizeFromUrl(url));
cachedImagedSizeResult.then(function () {
cachedImagedSize = getCachedImageSizeFromUrl.__get__('cache');
imageSizeSpy.calledOnce.should.be.true();
imageSizeSpy.calledTwice.should.be.false();
should.exist(cachedImagedSize);
cachedImagedSize.should.have.property(url);
should.exist(cachedImagedSize[url].width);
cachedImagedSize[url].width.should.be.equal(50);
should.exist(cachedImagedSize[url].height);
cachedImagedSize[url].height.should.be.equal(50);
done();
});
}).catch(done);
});
it('can handle image-size errors', function (done) {
const url = 'http://mysite.com/content/image/mypostcoverimage.jpg';
let cachedImagedSizeResult;
sizeOfStub.returns(new Promise.reject('error'));
revertGetCachedImageSizeFromUrl = getCachedImageSizeFromUrl.__set__('imageSize.getImageSizeFromUrl', sizeOfStub);
cachedImagedSizeResult = Promise.resolve(getCachedImageSizeFromUrl(url));
cachedImagedSizeResult.then(function () {
cachedImagedSize = getCachedImageSizeFromUrl.__get__('cache');
should.exist(cachedImagedSize);
cachedImagedSize.should.have.property(url);
should.not.exist(cachedImagedSize[url].width);
should.not.exist(cachedImagedSize[url].height);
done();
}).catch(done);
});
it('should return null if url is undefined', function (done) {
const url = null;
let result;
result = getCachedImageSizeFromUrl(url);
should.not.exist(result);
done();
});
});