0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
ghost/test/unit/server/services
Simon Backx 6b3a657f88
Renamed newsletter_id and email_recipient_filter options (#14798)
refs https://github.com/TryGhost/Team/issues/1596

- Renamed `newsletter_id` to `newsletter` option, the `newsletter` option expects a slug instead of an id
- Renamed `email_recipient_filter` to `email_segment` option
- Default `email_segment` to `all`. Ignored if no newsletter is set
- `email_segment` is ignored if no newsletter is set
- When reverting a post to a draft, both `newsletter` and `email_segment` are reset to their default values (null, all)
- Removed legacy mapping from old email_recipient_filter values 'paid' and 'free' (already a migration in place)
- Dropped legacy throwing errors when email_recipient_filter is paid or free in transformEmailRecipientFilter
- Reorganized transformEmailRecipientFilter parameters for the now required newsletter parameter
- Fixed an issue where the newsletter filter wasn't working because it wasn't in permittedoptions
- Fixed an issue where you could send to an archived newsletter
- Added an extra protection when scheduling to an active, and later archiving the newsletter
- Dropped support for `send_email_when_published` in API
- When importing posts we currently don't have a system in place to set the newsletter_id to map the `send_email_when_published` behaviour. Since this was already the case, I won't include a fix in this PR.
- Stripped `email_recipient_filter`/`email_segment` from Content API (https://ghost.slack.com/archives/C02G9E68C/p1652363211841359?thread_ts=1650623650.233229&cid=C02G9E68C)
- Updated `admin-api-schema` to 3.2.0, which includes the new email_segment property
- Contains a temporary fix for https://github.com/TryGhost/Team/issues/1626, where the `.related('newsletter').fetch` call fails when the newsletter relation is already loaded, because of the overridden `formatOnWrite` method.

Since the `email_recipient_filter` is no longer used without a newsletter, the `none` value is no longer used. A migration transforms all those values to `all`. This should be safe, because we only send an email now when newsletter_id is not null (scheduled posts should already have a newsletter_id, even if at the time of scheduling they didn't add the newsletter_id option, because at that time, we defaulted to the default newsletter).

Admin changes to make this work: https://github.com/TryGhost/Admin/pull/2380
2022-05-16 10:18:04 +02:00
..
adapter-manager
api-version-compatibility Fixed legacyApiPathMatch not working with subdirs 2022-05-10 13:57:06 +01:00
auth Swapped setup to use tiers API endpoint 2022-05-12 19:48:27 +01:00
frontend-data-service Added frontend key to ghost_head for portal (#14782) 2022-05-11 17:34:31 +01:00
mail Extracted email-content-generator into a package 2022-05-04 17:28:09 +08:00
mega Renamed newsletter_id and email_recipient_filter options (#14798) 2022-05-16 10:18:04 +02:00
members Removed settings that are no longer in use (#14802) 2022-05-13 21:19:21 +01:00
newsletters Fixed newsletter includes when adding or editing (#14696) 2022-05-05 11:20:15 +02:00
notifications Replace error handler middleware with @tryghost/mw-error-handler (#13879) 2021-12-14 15:18:46 +00:00
permissions
posts
redirects Slimmed down redirects test suites 2021-11-26 06:18:36 +13:00
route-settings Removed sync method from route settings loader 2022-04-28 15:37:09 +01:00
settings Added test coverage to settings bread service 2022-04-22 16:31:56 +08:00
stripe Removed settings that are no longer in use (#14802) 2022-05-13 21:19:21 +01:00
themes
url 🔥 Removed support for http/https mixed mode (#14783) 2022-05-11 14:53:23 +01:00
webhooks Improved assertions 2022-05-12 13:54:21 +08:00
labs.test.js
limits.test.js Fixed incorrect usage of limit config causing Ghost not to boot 2022-05-10 15:47:45 -04:00
slack.test.js Replaced schema.isPost in slack service /w custom fn 2022-04-05 14:24:42 +01:00
xmlrpc.test.js