Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity
ghost/test/utils/fixtures/themes
History
Rishabh Garg 36803a4290
🐛 Fixed incorrect @price.currency value in themes (#12987) 
closes https://github.com/TryGhost/Ghost/issues/12986
refs 1345268089

As part of changes in 4.6, the default price ids for monthly/yearly prices are stored in new settings - `members_monthly_price_id`, `members_yearly_price_id` - which are used to determine current active prices for the site from list of all existing prices. While the last commit updated the prices to use the settings, the data for currency was still used from non-zero prices instead of the new settings value.

- Updated tests to check price currency
2021-05-27 10:49:35 +05:30
..
broken-theme
casper Updated links to ghost.org sites 2021-01-20 09:59:45 +13:00
casper-1.4
price-data-test-theme 🐛 Fixed incorrect @price.currency value in themes (#12987) 2021-05-27 10:49:35 +05:30
test-theme Updated fixture for test theme to use @site 2021-03-04 01:09:54 +05:30
test-theme-channels
casper.zip
invalid.zip
README.md Bumped gscan to 4.0.0-pre.5 2021-03-04 21:18:27 +13:00
valid.zip Bumped gscan to 4.0.0-pre.5 2021-03-04 21:18:27 +13:00
warnings.zip

README.md

Modifying theme fixtures

When a new rule is introduced in gscan one of these fixture files might break and you'll have to update a "zip" which isn't as easy as opening a text editor... It could become that one day but for now here are some commands to help out with the edit process

  • Unzip the theme files, e.g.: cd $CURRENT_DIR && unzip valid.zip -d valid
  • Make a change in the file which caused a warning/error/whatever
  • Zip the files back: zip -r valid.zip ./valid
  • Commit changed zip file: git add valid.zip ;... you know the drill :)

Ideas for future improvements in theme tests:

  • Decouple tests from file system as much as possible
  • Track contents of what is in "zips" in source control. Right now, having a diff on a binary file is not useful at all