mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-17 23:44:39 -05:00
5abd67809d
refs https://github.com/TryGhost/Toolbox/issues/332 - After dropping support for `page: (true|false)` for post resources in Content API there is no need to check for `body.post.page` in the AMP renderer. Furthermore, the AMP router uses `public-post` controller that **only** returns "post" resources. This check was a redundant, unnecessary piece of logic
95 lines
2.9 KiB
JavaScript
95 lines
2.9 KiB
JavaScript
const path = require('path');
|
|
const express = require('../../../../shared/express');
|
|
const ampRouter = express.Router('amp');
|
|
|
|
const tpl = require('@tryghost/tpl');
|
|
const errors = require('@tryghost/errors');
|
|
|
|
// Dirty requires
|
|
const urlService = require('../../../../server/services/url');
|
|
const dataService = require('../../../services/data');
|
|
const renderer = require('../../../services/rendering');
|
|
const templateName = 'amp';
|
|
|
|
const messages = {
|
|
pageNotFound: 'Page not found.'
|
|
};
|
|
|
|
function _renderer(req, res, next) {
|
|
res.routerOptions = {
|
|
type: 'custom',
|
|
templates: templateName,
|
|
defaultTemplate: path.resolve(__dirname, 'views', `${templateName}.hbs`)
|
|
};
|
|
|
|
// Renderer begin
|
|
// Format data
|
|
let body = req.body || {};
|
|
|
|
if (!body.post) {
|
|
return next(new errors.NotFoundError({message: tpl(messages.pageNotFound)}));
|
|
}
|
|
|
|
// Render Call
|
|
return renderer.renderer(req, res, body);
|
|
}
|
|
|
|
// This here is a controller.
|
|
// In fact, this whole file is nothing more than a controller + renderer & doesn't need to be a router
|
|
function getPostData(req, res, next) {
|
|
req.body = req.body || {};
|
|
|
|
const urlWithoutSubdirectoryWithoutAmp = res.locals.relativeUrl.match(/(.*?\/)amp\/?$/)[1];
|
|
|
|
/**
|
|
* @NOTE
|
|
*
|
|
* We have to figure out the target permalink, otherwise it would be possible to serve a post
|
|
* which lives in two collections.
|
|
*
|
|
* @TODO:
|
|
*
|
|
* This is not optimal and caused by the fact how apps currently work. But apps weren't designed
|
|
* for dynamic routing.
|
|
*
|
|
* I think if the responsible, target router would first take care fetching/determining the post, the
|
|
* request could then be forwarded to this app. Then we don't have to:
|
|
*
|
|
* 1. care about fetching the post
|
|
* 2. care about if the post can be served
|
|
* 3. then this app would act like an extension
|
|
*
|
|
* The challenge is to design different types of apps e.g. extensions of routers, standalone pages etc.
|
|
*/
|
|
const permalinks = urlService.getPermalinkByUrl(urlWithoutSubdirectoryWithoutAmp, {withUrlOptions: true});
|
|
|
|
if (!permalinks) {
|
|
return next(new errors.NotFoundError({
|
|
message: tpl(messages.pageNotFound)
|
|
}));
|
|
}
|
|
|
|
// @NOTE: amp is not supported for "page" resource
|
|
// @TODO: https://github.com/TryGhost/Ghost/issues/10548
|
|
dataService.entryLookup(urlWithoutSubdirectoryWithoutAmp, {permalinks, query: {controller: 'postsPublic', resource: 'posts'}}, res.locals)
|
|
.then((result) => {
|
|
if (result && result.entry) {
|
|
req.body.post = result.entry;
|
|
}
|
|
|
|
next();
|
|
})
|
|
.catch(next);
|
|
}
|
|
|
|
// AMP frontend route
|
|
ampRouter
|
|
.route('/')
|
|
.get(
|
|
getPostData,
|
|
_renderer
|
|
);
|
|
|
|
module.exports = ampRouter;
|
|
module.exports.renderer = _renderer;
|
|
module.exports.getPostData = getPostData;
|