mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-03 23:00:14 -05:00
1882278b5b
- 🛠 add bunyan and prettyjson, remove morgan - ✨ add logging module - GhostLogger class that handles setup of bunyan - PrettyStream for stdout - ✨ config for logging - @TODO: testing level fatal? - ✨ log each request via GhostLogger (express middleware) - @TODO: add errors to output - 🔥 remove errors.updateActiveTheme - we can read the value from config - 🔥 remove 15 helper functions in core/server/errors/index.js - all these functions get replaced by modules: 1. logging 2. error middleware handling for html/json 3. error creation (which will be part of PR #7477) - ✨ add express error handler for html/json - one true error handler for express responses - contains still some TODO's, but they are not high priority for first implementation/integration - this middleware only takes responsibility of either rendering html responses or return json error responses - 🎨 use new express error handler in middleware/index - 404 and 500 handling - 🎨 return error instead of error message in permissions/index.js - the rule for error handling should be: if you call a unit, this unit should return a custom Ghost error - 🎨 wrap serve static module - rule: if you call a module/unit, you should always wrap this error - it's always the same rule - so the caller never has to worry about what comes back - it's always a clear error instance - in this case: we return our notfounderror if serve static does not find the resource - this avoid having checks everywhere - 🎨 replace usages of errors/index.js functions and adapt tests - use logging.error, logging.warn - make tests green - remove some usages of logging and throwing api errors -> because when a request is involved, logging happens automatically - 🐛 return errorDetails to Ghost-Admin - errorDetails is used for Theme error handling - 🎨 use 500er error for theme is missing error in theme-handler - 🎨 extend file rotation to 1w
140 lines
5.4 KiB
JavaScript
140 lines
5.4 KiB
JavaScript
var should = require('should'),
|
|
sinon = require('sinon'),
|
|
Promise = require('bluebird'),
|
|
|
|
// Stuff we're testing
|
|
db = require('../../server/data/db'),
|
|
errors = require('../../server/errors'),
|
|
exporter = require('../../server/data/export'),
|
|
schema = require('../../server/data/schema'),
|
|
settings = require('../../server/api/settings'),
|
|
|
|
schemaTables = Object.keys(schema.tables),
|
|
|
|
sandbox = sinon.sandbox.create();
|
|
|
|
describe('Exporter', function () {
|
|
var versionStub, tablesStub, queryMock, knexMock, knexStub;
|
|
|
|
afterEach(function () {
|
|
sandbox.restore();
|
|
knexStub.restore();
|
|
});
|
|
|
|
describe('doExport', function () {
|
|
beforeEach(function () {
|
|
versionStub = sandbox.stub(schema.versioning, 'getDatabaseVersion').returns(new Promise.resolve('004'));
|
|
tablesStub = sandbox.stub(schema.commands, 'getTables').returns(schemaTables);
|
|
|
|
queryMock = {
|
|
select: sandbox.stub()
|
|
};
|
|
|
|
knexMock = sandbox.stub().returns(queryMock);
|
|
|
|
// this MUST use sinon, not sandbox, see sinonjs/sinon#781
|
|
knexStub = sinon.stub(db, 'knex', {get: function () { return knexMock; }});
|
|
});
|
|
|
|
it('should try to export all the correct tables', function (done) {
|
|
// Setup for success
|
|
queryMock.select.returns(new Promise.resolve({}));
|
|
|
|
// Execute
|
|
exporter.doExport().then(function (exportData) {
|
|
// No tables, less the number of excluded tables
|
|
var expectedCallCount = schemaTables.length - 4;
|
|
|
|
should.exist(exportData);
|
|
|
|
versionStub.calledOnce.should.be.true();
|
|
tablesStub.calledOnce.should.be.true();
|
|
knexStub.get.called.should.be.true();
|
|
knexMock.called.should.be.true();
|
|
queryMock.select.called.should.be.true();
|
|
|
|
knexMock.callCount.should.eql(expectedCallCount);
|
|
queryMock.select.callCount.should.have.eql(expectedCallCount);
|
|
|
|
knexMock.getCall(0).args[0].should.eql('posts');
|
|
knexMock.getCall(1).args[0].should.eql('users');
|
|
knexMock.getCall(2).args[0].should.eql('roles');
|
|
knexMock.getCall(3).args[0].should.eql('roles_users');
|
|
knexMock.getCall(4).args[0].should.eql('permissions');
|
|
knexMock.getCall(5).args[0].should.eql('permissions_users');
|
|
knexMock.getCall(6).args[0].should.eql('permissions_roles');
|
|
knexMock.getCall(7).args[0].should.eql('permissions_apps');
|
|
knexMock.getCall(8).args[0].should.eql('settings');
|
|
knexMock.getCall(9).args[0].should.eql('tags');
|
|
knexMock.getCall(10).args[0].should.eql('posts_tags');
|
|
knexMock.getCall(11).args[0].should.eql('apps');
|
|
knexMock.getCall(12).args[0].should.eql('app_settings');
|
|
knexMock.getCall(13).args[0].should.eql('app_fields');
|
|
|
|
knexMock.calledWith('clients').should.be.false();
|
|
knexMock.calledWith('client_trusted_domains').should.be.false();
|
|
knexMock.calledWith('refreshtokens').should.be.false();
|
|
knexMock.calledWith('accesstokens').should.be.false();
|
|
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('should catch and log any errors', function (done) {
|
|
// Setup for failure
|
|
queryMock.select.returns(new Promise.reject({}));
|
|
|
|
// Execute
|
|
exporter.doExport().then(function () {
|
|
done(new Error('expected error on export data'));
|
|
}).catch(function (err) {
|
|
(err instanceof errors.InternalServerError).should.eql(true);
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('exportFileName', function () {
|
|
it('should return a correctly structured filename', function (done) {
|
|
var settingsStub = sandbox.stub(settings, 'read').returns(
|
|
new Promise.resolve({settings: [{value: 'testblog'}]})
|
|
);
|
|
|
|
exporter.fileName().then(function (result) {
|
|
should.exist(result);
|
|
settingsStub.calledOnce.should.be.true();
|
|
result.should.match(/^testblog\.ghost\.[0-9]{4}-[0-9]{2}-[0-9]{2}\.json$/);
|
|
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('should return a correctly structured filename if settings is empty', function (done) {
|
|
var settingsStub = sandbox.stub(settings, 'read').returns(
|
|
new Promise.resolve()
|
|
);
|
|
|
|
exporter.fileName().then(function (result) {
|
|
should.exist(result);
|
|
settingsStub.calledOnce.should.be.true();
|
|
result.should.match(/^ghost\.[0-9]{4}-[0-9]{2}-[0-9]{2}\.json$/);
|
|
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('should return a correctly structured filename if settings errors', function (done) {
|
|
var settingsStub = sandbox.stub(settings, 'read').returns(
|
|
new Promise.reject()
|
|
);
|
|
|
|
exporter.fileName().then(function (result) {
|
|
should.exist(result);
|
|
settingsStub.calledOnce.should.be.true();
|
|
result.should.match(/^ghost\.[0-9]{4}-[0-9]{2}-[0-9]{2}\.json$/);
|
|
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
});
|
|
});
|