mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-03 23:00:14 -05:00
1882278b5b
- 🛠 add bunyan and prettyjson, remove morgan - ✨ add logging module - GhostLogger class that handles setup of bunyan - PrettyStream for stdout - ✨ config for logging - @TODO: testing level fatal? - ✨ log each request via GhostLogger (express middleware) - @TODO: add errors to output - 🔥 remove errors.updateActiveTheme - we can read the value from config - 🔥 remove 15 helper functions in core/server/errors/index.js - all these functions get replaced by modules: 1. logging 2. error middleware handling for html/json 3. error creation (which will be part of PR #7477) - ✨ add express error handler for html/json - one true error handler for express responses - contains still some TODO's, but they are not high priority for first implementation/integration - this middleware only takes responsibility of either rendering html responses or return json error responses - 🎨 use new express error handler in middleware/index - 404 and 500 handling - 🎨 return error instead of error message in permissions/index.js - the rule for error handling should be: if you call a unit, this unit should return a custom Ghost error - 🎨 wrap serve static module - rule: if you call a module/unit, you should always wrap this error - it's always the same rule - so the caller never has to worry about what comes back - it's always a clear error instance - in this case: we return our notfounderror if serve static does not find the resource - this avoid having checks everywhere - 🎨 replace usages of errors/index.js functions and adapt tests - use logging.error, logging.warn - make tests green - remove some usages of logging and throwing api errors -> because when a request is involved, logging happens automatically - 🐛 return errorDetails to Ghost-Admin - errorDetails is used for Theme error handling - 🎨 use 500er error for theme is missing error in theme-handler - 🎨 extend file rotation to 1w
108 lines
3 KiB
JavaScript
108 lines
3 KiB
JavaScript
var https = require('https'),
|
|
url = require('url'),
|
|
Promise = require('bluebird'),
|
|
utils = require('../../utils'),
|
|
events = require('../../events'),
|
|
logging = require('../../logging'),
|
|
api = require('../../api/settings'),
|
|
i18n = require('../../i18n'),
|
|
schema = require('../schema').checks,
|
|
options,
|
|
req,
|
|
slackData = {};
|
|
|
|
function getSlackSettings() {
|
|
return api.read({context: {internal: true}, key: 'slack'}).then(function (response) {
|
|
var slackSetting = response.settings[0].value;
|
|
|
|
try {
|
|
slackSetting = JSON.parse(slackSetting);
|
|
} catch (e) {
|
|
return Promise.reject(e);
|
|
}
|
|
|
|
return slackSetting[0];
|
|
});
|
|
}
|
|
|
|
function makeRequest(reqOptions, reqPayload) {
|
|
req = https.request(reqOptions);
|
|
|
|
reqPayload = JSON.stringify(reqPayload);
|
|
|
|
req.write(reqPayload);
|
|
req.on('error', function (err) {
|
|
err.context = i18n.t('errors.data.xml.xmlrpc.pingUpdateFailed.error');
|
|
err.help = i18n.t('errors.data.xml.xmlrpc.pingUpdateFailed.help', {url: 'http://support.ghost.org'});
|
|
logging.error(err);
|
|
});
|
|
|
|
req.end();
|
|
}
|
|
|
|
function ping(post) {
|
|
var message;
|
|
|
|
// If this is a post, we want to send the link of the post
|
|
if (schema.isPost(post)) {
|
|
message = utils.url.urlFor('post', {post: post}, true);
|
|
} else {
|
|
message = post.message;
|
|
}
|
|
|
|
return getSlackSettings().then(function (slackSettings) {
|
|
// Quit here if slack integration is not activated
|
|
|
|
if (slackSettings.url && slackSettings.url !== '') {
|
|
// Only ping when not a page
|
|
if (post.page) {
|
|
return;
|
|
}
|
|
|
|
// Don't ping for the welcome to ghost post.
|
|
// This also handles the case where during ghost's first run
|
|
// models.init() inserts this post but permissions.init() hasn't
|
|
// (can't) run yet.
|
|
if (post.slug === 'welcome-to-ghost') {
|
|
return;
|
|
}
|
|
|
|
slackData = {
|
|
text: message,
|
|
unfurl_links: true,
|
|
icon_url: utils.url.urlFor({relativeUrl: '/ghost/img/ghosticon.jpg'}, {}, true),
|
|
username: 'Ghost'
|
|
};
|
|
|
|
// fill the options for https request
|
|
options = url.parse(slackSettings.url);
|
|
options.method = 'POST';
|
|
options.headers = {'Content-type': 'application/json'};
|
|
|
|
// with all the data we have, we're doing the request now
|
|
makeRequest(options, slackData);
|
|
} else {
|
|
return;
|
|
}
|
|
});
|
|
}
|
|
|
|
function listener(model) {
|
|
ping(model.toJSON());
|
|
}
|
|
|
|
function testPing() {
|
|
ping({
|
|
message: 'Heya! This is a test notification from your Ghost blog :simple_smile:. Seems to work fine!'
|
|
});
|
|
}
|
|
|
|
function listen() {
|
|
events.on('post.published', listener);
|
|
events.on('slack.test', testPing);
|
|
}
|
|
|
|
// Public API
|
|
module.exports = {
|
|
listen: listen
|
|
};
|