mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-06 22:40:14 -05:00
2768f5bb72
refs: https://github.com/TryGhost/Toolbox/issues/168 - The fixture represented Casper at Ghost version 1.0 which pre-dated the introduction of the posts_per_page config in package.json - When Casper was upgraded to 2.0 in the fixtures, the lack of pagination broke the e2e tests for pagination - This change introduces proper code to stub and override posts_per_page rather than keeping and using the old casper-1.4 fixture - It also required me to remove a handful of CSS-based checks which are no longer true in the new theme version, but also didn't really add anything to the tests |
||
|---|---|---|
| .. | ||
| broken-theme | ||
| casper | ||
| locale-theme | ||
| members-test-theme | ||
| test-theme | ||
| test-theme-channels | ||
| casper.zip | ||
| invalid.zip | ||
| README.md | ||
| valid.zip | ||
| warnings.zip | ||
Modifying theme fixtures
When a new rule is introduced in gscan one of these fixture files might break and you'll have to update a "zip" which isn't as easy as opening a text editor... It could become that one day but for now here are some commands to help out with the edit process
- Unzip the theme files, e.g.:
cd $CURRENT_DIR && unzip valid.zip -d valid - Make a change in the file which caused a warning/error/whatever
- Zip the files back:
zip -r valid.zip ./valid - Commit changed zip file:
git add valid.zip ;... you know the drill :)
Ideas for future improvements in theme tests:
- Decouple tests from file system as much as possible
- Track contents of what is in "zips" in source control. Right now, having a diff on a binary file is not useful at all