Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity
ghost/test/utils/fixtures/themes
History
Hannah Wolfe 40fee069c9
Moved locale testing out of casper fixture (#13850) 
refs: https://github.com/TryGhost/Toolbox/issues/137#issuecomment-986829141

- Moving the weird customisation of Casper out of the test fixture
- Created a standalone theme for testing locales instead
- This should make it easier for us to update our Casper fixture
2021-12-06 15:11:54 +00:00
..
broken-theme
casper Moved locale testing out of casper fixture (#13850) 2021-12-06 15:11:54 +00:00
casper-1.4
locale-theme Moved locale testing out of casper fixture (#13850) 2021-12-06 15:11:54 +00:00
price-data-test-theme
test-theme
test-theme-channels
casper.zip
invalid.zip
README.md
valid.zip Updated valid.zip to the latest casper version 2021-11-24 20:22:20 +01:00
warnings.zip

README.md

Modifying theme fixtures

When a new rule is introduced in gscan one of these fixture files might break and you'll have to update a "zip" which isn't as easy as opening a text editor... It could become that one day but for now here are some commands to help out with the edit process

  • Unzip the theme files, e.g.: cd $CURRENT_DIR && unzip valid.zip -d valid
  • Make a change in the file which caused a warning/error/whatever
  • Zip the files back: zip -r valid.zip ./valid
  • Commit changed zip file: git add valid.zip ;... you know the drill :)

Ideas for future improvements in theme tests:

  • Decouple tests from file system as much as possible
  • Track contents of what is in "zips" in source control. Right now, having a diff on a binary file is not useful at all