mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-17 23:44:39 -05:00
04c60b4ce1
no issue - Reported here: https://forum.ghost.org/t/in-version-2-16-3-found-bug/6065/3 --- Admin Client sends false or true booleans for `is_private` key. The settings table has two columns "key" and "value". And "value" is always type TEXT. If you pass value=false, the db will transform this value into "0". `settingsCache.get('is_private')` is then always true, even though the value is meant to be false. We should add a migration in v3 and normalize all setting values to ensure consistent database values. Furthermore, we should improve the handling around settings values in general. For now, we protect parsing values from DB, which we anyway need to transform the values into the correct data type, because we always save strings. This will protect values being stored as "false" or "1" or whatever. |
||
|---|---|---|
| .. | ||
| actions_spec.js | ||
| config_spec.js | ||
| db_spec.js | ||
| images_spec.js | ||
| integrations_spec.js | ||
| invites_spec.js | ||
| key_authentication_spec.js | ||
| mail_spec.js | ||
| notifications_spec.js | ||
| oembed_spec.js | ||
| pages_spec.js | ||
| posts_spec.js | ||
| roles_spec.js | ||
| settings_spec.js | ||
| slugs_spec.js | ||
| tags_spec.js | ||
| themes_spec.js | ||
| users_spec.js | ||
| utils.js | ||
| webhooks_spec.js | ||