mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-03 23:00:14 -05:00
22e13acd65
- All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!
36 lines
1.1 KiB
JavaScript
36 lines
1.1 KiB
JavaScript
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const common = require('../../../../../core/server/lib/common');
|
|
const helpers = require('../../../../../core/frontend/services/routing/helpers');
|
|
|
|
describe('handleError', function () {
|
|
let next;
|
|
|
|
beforeEach(function () {
|
|
next = sinon.spy();
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
it('should call next with no args for 404 errors', function () {
|
|
const notFoundError = new common.errors.NotFoundError({message: 'Something wasn\'t found'});
|
|
helpers.handleError(next)(notFoundError);
|
|
|
|
next.calledOnce.should.be.true();
|
|
next.firstCall.args.should.be.empty();
|
|
});
|
|
|
|
it('should call next with error for other errors', function () {
|
|
const otherError = new Error();
|
|
otherError.message = 'Something wasn\'t allowed';
|
|
|
|
helpers.handleError(next)(otherError);
|
|
|
|
next.calledOnce.should.be.true();
|
|
next.firstCall.args.should.have.lengthOf(1);
|
|
next.firstCall.args[0].should.be.an.Object();
|
|
next.firstCall.args[0].should.be.instanceof(Error);
|
|
});
|
|
});
|