0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
ghost/core/server/services/mega
Simon Backx 5657019e47
Fixed wrong newsletter used when sending scheduled post (#14734)
refs https://ghost.slack.com/archives/C02G9E68C/p1651939076681719

Cause:
- When a scheduled post was published via the post scheduler, no `newsletter_id` option is passed when editing the post.
- When editing a post via the posts service, without the `newsletter_id` option, the `newsletter_id` option is automatically set to the default newsletter's id.
- Inside the post model, this new `newsletter_id` was not saved, because it was already set, and changing it is prevented.
- The `mega` service wasn't using the (unchanged) post's newsletter_id, but used the option instead, which contained the default newsletter's id.

Fix:
- Always using the newsletter_id from the post and requiring the newsletter associated with a post to exist.
- This behaviour can be/is tested by publishing a scheduled post without any option.

Also cleaned up some `Object.assign` usages.
2022-05-09 17:30:50 +02:00
..
email-preview.js Removed API versioning from email serialization 2022-04-28 15:37:06 +01:00
index.js
mega.js Fixed wrong newsletter used when sending scheduled post (#14734) 2022-05-09 17:30:50 +02:00
post-email-serializer.js Added newsletter info to email unsubscribe url (#14693) 2022-05-05 11:00:24 +05:30
segment-parser.js Lazy loaded cheerio dependency 2021-11-18 17:31:04 +01:00
template.js Updated emails to use newsletter settings (#14588) 2022-04-27 18:48:36 +01:00