mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-10 23:36:14 -05:00
15978689c0
refs TryGhost/Team#535 We want to ensure that a site will always have a default value of `'#15171A'` for the accent_color setting. Since the boot process changed we have three cases to account for: 1. Setting does not exist 2. Setting exists with no value 3. Setting exists with a value It is only in the case of 2. that we want the migration to update the database with a default value. In the case of 3. the site owner has already set a value, which we do not want to override. In the case of 1. the setting will be created (and populated with default value) from the default-settings.json file, by the populateDefaults method called from the settings service We also update the accent_color setting to include a non-empty validation, to ensure that the setting will always have a value, as sites before 4.x may have an empty accent_color, we must update the importer to set the default value if one is not present. Otherwise we would run into validation errors and even if we didn't would have an invalid database state.
69 lines
3.1 KiB
JavaScript
69 lines
3.1 KiB
JavaScript
const should = require('should');
|
|
const _ = require('lodash');
|
|
const yaml = require('js-yaml');
|
|
const crypto = require('crypto');
|
|
const fs = require('fs-extra');
|
|
const path = require('path');
|
|
const {config} = require('../../../utils/configUtils');
|
|
const schema = require('../../../../core/server/data/schema');
|
|
const fixtures = require('../../../../core/server/data/schema/fixtures');
|
|
const frontendSettings = require('../../../../core/frontend/services/settings');
|
|
const validateFrontendSettings = require('../../../../core/frontend/services/settings/validate');
|
|
const defaultSettings = require('../../../../core/server/data/schema/default-settings');
|
|
|
|
/**
|
|
* @NOTE
|
|
*
|
|
* If this test fails for you, you have modified one of:
|
|
* - the database schema
|
|
* - fixtures
|
|
* - default settings
|
|
* - routes.yaml
|
|
*
|
|
* When you make a change, please test that:
|
|
*
|
|
* 1. A new blog get's installed and the database looks correct and complete.
|
|
* 2. A blog get's updated from a lower Ghost version and the database looks correct and complete.
|
|
*
|
|
* Typical cases:
|
|
* You have to add a migration script if you've added/modified permissions.
|
|
* You have to add a migration script if you've add a new table.
|
|
* You have to add a migration script if you've added new settings to populate group/flags column.
|
|
*/
|
|
describe('DB version integrity', function () {
|
|
// Only these variables should need updating
|
|
const currentSchemaHash = '559cdbb49a7eeb5758caf0c6e3bf790d';
|
|
const currentFixturesHash = '5f6f69931811c407dff01da9ef9667f4';
|
|
const currentSettingsHash = 'a787bc3c1812b56a498b9ac5f8900f63';
|
|
const currentRoutesHash = '3d180d52c663d173a6be791ef411ed01';
|
|
|
|
// If this test is failing, then it is likely a change has been made that requires a DB version bump,
|
|
// and the values above will need updating as confirmation
|
|
it('should not change without fixing this test', function () {
|
|
const routesPath = path.join(config.get('paths').defaultSettings, 'default-routes.yaml');
|
|
const defaultRoutes = validateFrontendSettings(yaml.load(fs.readFileSync(routesPath, 'utf-8')));
|
|
|
|
const tablesNoValidation = _.cloneDeep(schema.tables);
|
|
let schemaHash;
|
|
let fixturesHash;
|
|
let settingsHash;
|
|
let routesHash;
|
|
|
|
_.each(tablesNoValidation, function (table) {
|
|
return _.each(table, function (column, name) {
|
|
table[name] = _.omit(column, 'validations');
|
|
});
|
|
});
|
|
|
|
schemaHash = crypto.createHash('md5').update(JSON.stringify(tablesNoValidation), 'binary').digest('hex');
|
|
fixturesHash = crypto.createHash('md5').update(JSON.stringify(fixtures), 'binary').digest('hex');
|
|
settingsHash = crypto.createHash('md5').update(JSON.stringify(defaultSettings), 'binary').digest('hex');
|
|
routesHash = crypto.createHash('md5').update(JSON.stringify(defaultRoutes), 'binary').digest('hex');
|
|
|
|
schemaHash.should.eql(currentSchemaHash);
|
|
fixturesHash.should.eql(currentFixturesHash);
|
|
settingsHash.should.eql(currentSettingsHash);
|
|
routesHash.should.eql(currentRoutesHash);
|
|
routesHash.should.eql(frontendSettings.getDefaulHash('routes'));
|
|
});
|
|
});
|