0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-25 02:31:59 -05:00
ghost/core
Hannah Wolfe 0ef5a5c97a
Fixed members connect endpoint returning JSON
refs: https://github.com/TryGhost/Toolbox/issues/245
refs: https://github.com/TryGhost/Team/issues/1360

- As a result of my changes in https://github.com/TryGhost/Ghost/commit/3bd4d098 the members connect endpoint had started returning JSON
- This is because the members connect endpoint relied on the old default behaviour of the serializer being to return no response, whereas now it does our default JSON response format
- I had written a tool to iterate over all endpoints and ensure that they all had explicit serializers before changing the default behaviour, but it missed this endpoint due to the snake case naming
- I have double checked and this was the only missed endpoint, the only other one was member_signin_urls.permissions but that was not a true endpoint and was removed in https://github.com/TryGhost/Ghost/commit/202696382
- Note: the snapshot file for this test was generated from running the test against https://github.com/TryGhost/Ghost/commit/e6b92aed9 - one commit before I added the new default behaviour.
  - Without the new serializer this test fails on main
  - With the new serialzier, this test passes again, showing the response format has gone back to what we expect
2022-03-24 17:09:23 +00:00
..
client@5552aeb12b Updated Admin to v4.41.2 2022-03-23 15:06:02 +00:00
frontend Fixed theme error handler (#14363) 2022-03-22 15:32:55 +00:00
server Fixed members connect endpoint returning JSON 2022-03-24 17:09:23 +00:00
shared Revert "Refined UI/UX for Portal" 2022-03-24 16:34:47 +05:30
app.js Fixed express app stacking 2021-12-06 21:28:53 +13:00
boot.js Added theme-service-init metric during boot 2022-03-24 09:20:52 +00:00
bridge.js 💡 Pinned frontend API version to canary 2022-02-17 17:55:55 +00:00