0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
ghost/test/unit
Naz 0962b3ed45 Made custom-redirects middleware testable
refs https://linear.app/tryghost/issue/CORE-35/refactor-route-and-redirect-settings
refs 7528ec8c3b

- The way the custom redirects middleware was organized made it extremely hard to unit test it (had to stub the redirects service methods etc). With a new organization it's possible to provide needed redirects configs to the method which makes the actual redirects Router logic testable and the code less coupled with redirects services
- This was meant to be an attempt to extract more of the slow redirects regression tests, which failed. Instead found this weak spot that could be improved and gained:
- shaved 4s of time as two slow regression test cases are now gone
- there's now a base to build upon when getting more coverage for the custom redirects middleware
2021-09-28 22:00:32 +02:00
..
adapters Refactored scheduling default test to use nock 2021-07-15 14:07:11 +04:00
api Fixed failing unit test 2021-08-13 10:22:11 +04:00
apps Renamed tests to .test.js & updated commands 2021-07-06 20:45:01 +01:00
data Moved routing setting hash calculation to backend 2021-09-28 04:59:41 +13:00
helpers Fixed logic bugs in match helper (#13315) 2021-09-17 09:47:10 +01:00
lib Blocked 0.* IP addresses when making oembed requests 2021-09-14 11:35:14 +01:00
meta Renamed tests to .test.js & updated commands 2021-07-06 20:45:01 +01:00
models Fixed settings tests due to Bookshelf update 2021-09-10 16:59:11 +01:00
server Renamed tests to .test.js & updated commands 2021-07-06 20:45:01 +01:00
services Moved validate&yaml-parser modules to backend 2021-09-28 04:59:41 +13:00
shared Renamed tests to .test.js & updated commands 2021-07-06 20:45:01 +01:00
web Made custom-redirects middleware testable 2021-09-28 22:00:32 +02:00